From: David Miller <davem@davemloft.net>
To: jbohac@suse.cz
Cc: fubar@us.ibm.com, bonding-devel@lists.sourceforge.net,
netdev@vger.kernel.org
Subject: Re: [PATCH] bonding: fix arp_validate on bonds inside a bridge
Date: Thu, 06 May 2010 00:35:23 -0700 (PDT) [thread overview]
Message-ID: <20100506.003523.214214350.davem@davemloft.net> (raw)
In-Reply-To: <20100505133301.GA18493@midget.suse.cz>
From: Jiri Bohac <jbohac@suse.cz>
Date: Wed, 5 May 2010 15:33:01 +0200
> If either of the ptype_all or ptype_base_predecap[] method is
> preferred, I'll be happy to re-work the patch. I just thought
> performance had bigger priority here.
Well, let's do some thinking.
If there are any ptype_all[] entries at all, processing of every
packet will be expensive.
Also, the ptype_base_predecap[] is unlikely to have any entries
unless bonding is on in this special mode. But if it is, we
can accept a little bit of extra overhead.
So we can address all of this without adding undue overhead for people
not using this stuff, by simply having an atomic counter which shows
how many ptype_all[] or ptype_base_predecap[] entries exist.
And at the top level we test that __read_mostly atomic variable before
traversing the ptype_all[] and ptype_base_predecap[] lists.
That should address all of the issues.
prev parent reply other threads:[~2010-05-06 7:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-28 12:59 [PATCH] bonding: fix arp_validate on bonds inside a bridge Jiri Bohac
2010-04-28 19:05 ` Jay Vosburgh
[not found] ` <20100429163921.GA4228@midget.suse.cz>
2010-04-29 18:57 ` Jay Vosburgh
2010-04-30 15:45 ` Jiri Bohac
2010-05-03 22:58 ` David Miller
2010-05-03 23:02 ` Jay Vosburgh
2010-05-04 1:06 ` Jay Vosburgh
2010-05-04 23:18 ` David Miller
2010-05-05 13:33 ` Jiri Bohac
2010-05-06 7:35 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100506.003523.214214350.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bonding-devel@lists.sourceforge.net \
--cc=fubar@us.ibm.com \
--cc=jbohac@suse.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).