From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: martin.ferrari@gmail.com, arnd@arndb.de, netdev@vger.kernel.org,
mathieu.lacage@sophia.inria.fr
Subject: Re: kernel panic when using netns+bridges+tc(netem)
Date: Thu, 06 May 2010 00:54:25 -0700 (PDT) [thread overview]
Message-ID: <20100506.005425.220063166.davem@davemloft.net> (raw)
In-Reply-To: <1273129187.2304.14.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Thu, 06 May 2010 08:59:47 +0200
> David, this is a stable candidate, once tested and acked, thanks !
>
> [PATCH] veth: Dont kfree_skb() after dev_forward_skb()
>
> In case of congestion, netif_rx() frees the skb, so we must assume
> dev_forward_skb() also consume skb.
>
> Bug introduced by commit 445409602c092
> (veth: move loopback logic to common location)
>
> We must change dev_forward_skb() to always consume skb, and veth to not
> double free it.
>
> Bug report : http://marc.info/?l=linux-netdev&m=127310770900442&w=3
>
> Reported-by: Martín Ferrari <martin.ferrari@gmail.com>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Ugh, applied and queued up for -stable, thanks Eric!
next prev parent reply other threads:[~2010-05-06 7:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-06 1:01 kernel panic when using netns+bridges+tc(netem) Martín Ferrari
2010-05-06 6:40 ` Eric Dumazet
2010-05-06 6:47 ` Eric Dumazet
2010-05-06 6:59 ` Eric Dumazet
2010-05-06 7:54 ` David Miller [this message]
2010-05-06 11:23 ` Martín Ferrari
2010-05-06 19:15 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100506.005425.220063166.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=arnd@arndb.de \
--cc=eric.dumazet@gmail.com \
--cc=martin.ferrari@gmail.com \
--cc=mathieu.lacage@sophia.inria.fr \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox