* [PATCH 5/8] ethoc: Remove unnecessary memset of napi member in netdev private data
@ 2010-05-06 15:41 Tobias Klauser
2010-05-07 5:11 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Tobias Klauser @ 2010-05-06 15:41 UTC (permalink / raw)
To: davem, netdev; +Cc: kernel-janitors, Tobias Klauser
The memory for the private data is allocated using kzalloc in
alloc_etherdev (or alloc_netdev_mq respectively) so there is no need to
set the napi member it to 0 explicitely.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
---
drivers/net/ethoc.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ethoc.c b/drivers/net/ethoc.c
index 6bd03c8..ad1bc73 100644
--- a/drivers/net/ethoc.c
+++ b/drivers/net/ethoc.c
@@ -1040,7 +1040,6 @@ static int ethoc_probe(struct platform_device *pdev)
netdev->features |= 0;
/* setup NAPI */
- memset(&priv->napi, 0, sizeof(priv->napi));
netif_napi_add(netdev, &priv->napi, ethoc_poll, 64);
spin_lock_init(&priv->rx_lock);
--
1.6.3.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 5/8] ethoc: Remove unnecessary memset of napi member in netdev private data
2010-05-06 15:41 [PATCH 5/8] ethoc: Remove unnecessary memset of napi member in netdev private data Tobias Klauser
@ 2010-05-07 5:11 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-05-07 5:11 UTC (permalink / raw)
To: tklauser; +Cc: netdev, kernel-janitors
From: Tobias Klauser <tklauser@distanz.ch>
Date: Thu, 6 May 2010 17:41:12 +0200
> The memory for the private data is allocated using kzalloc in
> alloc_etherdev (or alloc_netdev_mq respectively) so there is no need to
> set the napi member it to 0 explicitely.
>
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-05-07 5:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-06 15:41 [PATCH 5/8] ethoc: Remove unnecessary memset of napi member in netdev private data Tobias Klauser
2010-05-07 5:11 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).