* [PATCH 6/8] smc9194: Remove unnecessary memset of netdev private data
@ 2010-05-06 15:41 Tobias Klauser
2010-05-07 5:11 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Tobias Klauser @ 2010-05-06 15:41 UTC (permalink / raw)
To: davem, netdev; +Cc: kernel-janitors, Tobias Klauser
The memory for the private data is allocated using kzalloc in
alloc_etherdev (or alloc_netdev_mq respectively) so there is no need to
set it to 0 again.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
---
drivers/net/smc9194.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/drivers/net/smc9194.c b/drivers/net/smc9194.c
index e94521c..d76c815 100644
--- a/drivers/net/smc9194.c
+++ b/drivers/net/smc9194.c
@@ -1042,9 +1042,6 @@ static int __init smc_probe(struct net_device *dev, int ioaddr)
*/
printk("ADDR: %pM\n", dev->dev_addr);
- /* set the private data to zero by default */
- memset(netdev_priv(dev), 0, sizeof(struct smc_local));
-
/* Grab the IRQ */
retval = request_irq(dev->irq, smc_interrupt, 0, DRV_NAME, dev);
if (retval) {
--
1.6.3.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 6/8] smc9194: Remove unnecessary memset of netdev private data
2010-05-06 15:41 [PATCH 6/8] smc9194: Remove unnecessary memset of netdev private data Tobias Klauser
@ 2010-05-07 5:11 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-05-07 5:11 UTC (permalink / raw)
To: tklauser; +Cc: netdev, kernel-janitors
From: Tobias Klauser <tklauser@distanz.ch>
Date: Thu, 6 May 2010 17:41:31 +0200
> The memory for the private data is allocated using kzalloc in
> alloc_etherdev (or alloc_netdev_mq respectively) so there is no need to
> set it to 0 again.
>
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-05-07 5:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-06 15:41 [PATCH 6/8] smc9194: Remove unnecessary memset of netdev private data Tobias Klauser
2010-05-07 5:11 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).