From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: andrew.hendry@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH] X25: Replace BKL in sockopts calls
Date: Mon, 10 May 2010 04:44:48 -0700 (PDT) [thread overview]
Message-ID: <20100510.044448.129759879.davem@davemloft.net> (raw)
In-Reply-To: <1273467040.2325.78.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Mon, 10 May 2010 06:50:40 +0200
> Well, its probably better than lock_kernel() ;)
>
> qbitincl is a char, I suspect some arches cant store a char in an atomic
> way ? Alpha comes to mind.
True.
> We now have lock_sock_bh()/unlock_sock_bh() for this kind of very short
> sections, where we cant sleep.
Another option is to simply use an atomic bitmask to represent these
booleans instead of a crufty set of chars.
prev parent reply other threads:[~2010-05-10 11:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-09 12:45 [PATCH] X25: Replace BKL in sockopts calls Andrew Hendry
2010-05-10 1:46 ` David Miller
2010-05-10 4:50 ` Eric Dumazet
2010-05-10 11:44 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100510.044448.129759879.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew.hendry@gmail.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).