From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org, Eilon Greenstein <eilong@broadcom.com>,
Vladislav Zolotarov <vladz@broadcom.com>,
Dmitry Kravkov <dmitry@broadcom.com>,
Michael Chan <mchan@broadcom.com>,
Breno Leitao <leitao@linux.vnet.ibm.com>,
Matt Carlson <mcarlson@broadcom.com>
Subject: Re: [PATCH net-next] bnx2x: avoid TX timeout when stopping device
Date: Wed, 12 May 2010 12:58:15 +0200 [thread overview]
Message-ID: <20100512125815.0dad8ad0@dhcp-lab-109.englab.brq.redhat.com> (raw)
In-Reply-To: <1273656458.2621.22.camel@edumazet-laptop>
On Wed, 12 May 2010 11:27:38 +0200
Eric Dumazet <eric.dumazet@gmail.com> wrote:
> Le mercredi 12 mai 2010 à 11:09 +0200, Stanislaw Gruszka a écrit :
> > When stop device call netif_carrier_off() just after disabling TX queue to
> > avoid possibility of netdev watchdog warning and ->ndo_tx_timeout() invocation.
> >
> > Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com>
> > ---
>
> This reminds me I saw some strange things in bnx2.c for a similar
> symptom.
>
> Commit e6bf95ffa8d6f8f4b7ee33ea01490d95b0bbeb6e
>
> Would you take a look at this too ?
I can send RFC patch for bnx2, and tg3 as I think it needs similar fix.
> Or if this kind of trans_start refresh on all queues is really needed,
> it should be a core network provided function, not implemented on every
> driver...
I think netif_carrier_off() should be used, since touching trans_start make
timeout only less probable, but not prevent it.
Stanislaw
next prev parent reply other threads:[~2010-05-12 10:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-12 9:09 [PATCH net-next] bnx2x: avoid TX timeout when stopping device Stanislaw Gruszka
2010-05-12 9:27 ` Eric Dumazet
2010-05-12 10:58 ` Stanislaw Gruszka [this message]
2010-05-12 11:06 ` [RFC PATCH] bnx2: use netif_carrier_off to prevent tx timeout Stanislaw Gruszka
2010-05-12 11:16 ` [RFC PATCH] tg3: " Stanislaw Gruszka
2010-05-12 13:31 ` [RFC PATCH] bnx2: " Michael Chan
2010-05-12 14:00 ` Stanislaw Gruszka
2010-05-12 14:09 ` Michael Chan
2010-05-12 11:19 ` [PATCH net-next] bnx2x: avoid TX timeout when stopping device Eilon Greenstein
2010-05-12 12:37 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100512125815.0dad8ad0@dhcp-lab-109.englab.brq.redhat.com \
--to=sgruszka@redhat.com \
--cc=dmitry@broadcom.com \
--cc=eilong@broadcom.com \
--cc=eric.dumazet@gmail.com \
--cc=leitao@linux.vnet.ibm.com \
--cc=mcarlson@broadcom.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=vladz@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).