From: Stanislaw Gruszka <sgruszka@redhat.com>
To: "Michael Chan" <mchan@broadcom.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Eric Dumazet" <eric.dumazet@gmail.com>,
"Eilon Greenstein" <eilong@broadcom.com>,
"Vladislav Zolotarov" <vladz@broadcom.com>,
"Dmitry Kravkov" <dmitry@broadcom.com>,
"Breno Leitao" <leitao@linux.vnet.ibm.com>,
"Matthew Carlson" <mcarlson@broadcom.com>
Subject: Re: [RFC PATCH] bnx2: use netif_carrier_off to prevent tx timeout
Date: Wed, 12 May 2010 16:00:36 +0200 [thread overview]
Message-ID: <20100512160036.1f69fd23@dhcp-lab-109.englab.brq.redhat.com> (raw)
In-Reply-To: <C27F8246C663564A84BB7AB3439772421B6C41FC55@IRVEXCHCCR01.corp.ad.broadcom.com>
On Wed, 12 May 2010 06:31:52 -0700
"Michael Chan" <mchan@broadcom.com> wrote:
> > @@ -6346,6 +6338,8 @@ bnx2_vlan_rx_register(struct net_device
> > *dev, struct vlan_group *vlgrp)
> > if (bp->flags & BNX2_FLAG_CAN_KEEP_VLAN)
> > bnx2_fw_sync(bp,
> > BNX2_DRV_MSG_CODE_KEEP_VLAN_UPDATE, 0, 1);
> >
> > + if (bp->link_up)
> > + netif_carrier_on(bp->dev);
>
> Thanks Stanislaw, I think it is better to turn carrier on in
> bnx2_netif_start(). We can use the start_cnic parameter to
> decide if we need to call carrier_on().
IIRC in most cases we set carrier status in bnx2_init_nic()
(based on what we get from PHY) called before bnx2_netif_start().
One exception is bnx2_vlan_rx_register() function.
Thanks
Stanislaw
next prev parent reply other threads:[~2010-05-12 13:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-12 9:09 [PATCH net-next] bnx2x: avoid TX timeout when stopping device Stanislaw Gruszka
2010-05-12 9:27 ` Eric Dumazet
2010-05-12 10:58 ` Stanislaw Gruszka
2010-05-12 11:06 ` [RFC PATCH] bnx2: use netif_carrier_off to prevent tx timeout Stanislaw Gruszka
2010-05-12 11:16 ` [RFC PATCH] tg3: " Stanislaw Gruszka
2010-05-12 13:31 ` [RFC PATCH] bnx2: " Michael Chan
2010-05-12 14:00 ` Stanislaw Gruszka [this message]
2010-05-12 14:09 ` Michael Chan
2010-05-12 11:19 ` [PATCH net-next] bnx2x: avoid TX timeout when stopping device Eilon Greenstein
2010-05-12 12:37 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100512160036.1f69fd23@dhcp-lab-109.englab.brq.redhat.com \
--to=sgruszka@redhat.com \
--cc=dmitry@broadcom.com \
--cc=eilong@broadcom.com \
--cc=eric.dumazet@gmail.com \
--cc=leitao@linux.vnet.ibm.com \
--cc=mcarlson@broadcom.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=vladz@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).