From: Chris Wright <chrisw@redhat.com>
To: Patrick McHardy <kaber@trash.net>
Cc: Chris Wright <chrisw@redhat.com>,
Scott Feldman <scofeldm@cisco.com>,
davem@davemloft.net, netdev@vger.kernel.org, arnd@arndb.de
Subject: Re: [net-next-2.6 V6 PATCH 1/2] Add netlink support for virtual port management (was iovnl)
Date: Thu, 13 May 2010 14:08:28 -0700 [thread overview]
Message-ID: <20100513210828.GD30483@x200.localdomain> (raw)
In-Reply-To: <4BEC65BC.5040208@trash.net>
* Patrick McHardy (kaber@trash.net) wrote:
> Chris Wright wrote:
> > * Patrick McHardy (kaber@trash.net) wrote:
> >>> + } else {
> >>> + err = rtnl_vf_port_fill_nest(skb, dev, -1);
> >> What does -1 mean?
> >
> > It means no VFs. Could be made a macro/enum constant
>
> Why call rtnl_vg_port_fill_nest at all in that case? It even
> calls the ndo_get_vf_port() callback.
For the case where port profile is set on net dev that does not
have VFs (e.g. the enic case in 2/2).
thanks,
-chris
next prev parent reply other threads:[~2010-05-13 21:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-13 20:17 [net-next-2.6 V6 PATCH 0/2] Add virtual port netlink support Scott Feldman
2010-05-13 20:17 ` [net-next-2.6 V6 PATCH 1/2] Add netlink support for virtual port management (was iovnl) Scott Feldman
2010-05-13 20:28 ` Chris Wright
2010-05-13 20:40 ` Patrick McHardy
2010-05-13 20:46 ` Chris Wright
2010-05-13 20:49 ` Patrick McHardy
2010-05-13 21:08 ` Chris Wright [this message]
2010-05-13 21:11 ` Patrick McHardy
2010-05-13 21:18 ` Chris Wright
2010-05-13 21:23 ` Patrick McHardy
2010-05-14 7:17 ` Arnd Bergmann
2010-05-13 21:30 ` Scott Feldman
2010-05-14 10:47 ` Patrick McHardy
2010-05-13 20:17 ` [net-next-2.6 V6 PATCH 2/2] Add ndo_{set|get}_vf_port support for enic dynamic vnics Scott Feldman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100513210828.GD30483@x200.localdomain \
--to=chrisw@redhat.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=scofeldm@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).