From: David Miller <davem@davemloft.net>
To: joe@perches.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH V2 net-next] drivers/net: Remove unnecessary returns from void function()s
Date: Fri, 14 May 2010 00:19:45 -0700 (PDT) [thread overview]
Message-ID: <20100514.001945.52204757.davem@davemloft.net> (raw)
In-Reply-To: <1273816980.1583.40.camel@Joe-Laptop.home>
From: Joe Perches <joe@perches.com>
Date: Thu, 13 May 2010 23:03:00 -0700
> On Thu, 2010-05-13 at 19:09 -0700, David Miller wrote:
>> Ok, please remake this patch with those cases removed.
>
> This patch removes from drivers/net/ all the unnecessary
> return; statements that precede the last closing brace of
> void functions.
>
> It does not remove the returns that are immediately
> preceded by a label as gcc doesn't like that.
>
> It also does not remove null void functions with return.
>
> Done via:
> $ grep -rP --include=*.[ch] -l "return;\n}" net/ | \
> xargs perl -i -e 'local $/ ; while (<>) { s/\n[ \t\n]+return;\n}/\n}/g; print; }'
>
> with some cleanups by hand.
>
> Compile tested x86 allmodconfig only.
>
> Signed-off-by: Joe Perches <joe@perches.com>
Applied, thanks a lot Joe.
prev parent reply other threads:[~2010-05-14 7:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-11 19:30 [PATCH net-next] drivers/net: Remove unnecessary returns from void function()s Joe Perches
2010-05-13 16:58 ` Joe Perches
2010-05-13 18:37 ` Harvey Harrison
2010-05-14 2:09 ` David Miller
2010-05-14 6:03 ` [PATCH V2 " Joe Perches
2010-05-14 7:19 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100514.001945.52204757.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=joe@perches.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).