From: David Miller <davem@davemloft.net>
To: jeffrey.t.kirsher@intel.com
Cc: netdev@vger.kernel.org, gospo@redhat.com, joe@perches.com
Subject: Re: [net-next-2.6 PATCH 3/3] ixgb and e1000: Use new function for copybreak tests
Date: Fri, 14 May 2010 03:14:50 -0700 (PDT) [thread overview]
Message-ID: <20100514.031450.45911891.davem@davemloft.net> (raw)
In-Reply-To: <20100514012615.30457.37881.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Thu, 13 May 2010 18:26:17 -0700
> From: Joe Perches <joe@perches.com>
>
> There appears to be an off-by-1 defect in the maximum packet size
> copied when copybreak is speified in these modules.
>
> The copybreak module params are specified as:
> "Maximum size of packet that is copied to a new buffer on receive"
>
> The tests are changed from "< copybreak" to "<= copybreak"
> and moved into new static functions for readability.
>
> Signed-off-by: Joe Perches <joe@perches.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
next prev parent reply other threads:[~2010-05-14 10:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-14 1:25 [net-next-2.6 PATCH 1/3] e1000: fix WARN_ON with mac-vlan Jeff Kirsher
2010-05-14 1:25 ` [net-next-2.6 PATCH 2/3] e1000: cleanup unused parameters Jeff Kirsher
2010-05-14 10:14 ` David Miller
2010-05-14 1:26 ` [net-next-2.6 PATCH 3/3] ixgb and e1000: Use new function for copybreak tests Jeff Kirsher
2010-05-14 10:14 ` David Miller [this message]
2010-05-14 10:14 ` [net-next-2.6 PATCH 1/3] e1000: fix WARN_ON with mac-vlan David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100514.031450.45911891.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=joe@perches.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).