From: David Miller <davem@davemloft.net>
To: shemminger@vyatta.com
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
simon@fire.lp0.eu
Subject: Re: [PATCH 4/4] bridge: update sysfs link names if port device names have changed
Date: Sat, 15 May 2010 23:12:29 -0700 (PDT) [thread overview]
Message-ID: <20100515.231229.186295968.davem@davemloft.net> (raw)
In-Reply-To: <20100510193321.020451781@vyatta.com>
From: Stephen Hemminger <shemminger@vyatta.com>
Date: Mon, 10 May 2010 12:31:11 -0700
> From: Simon Arlott <simon@fire.lp0.eu>
>
> Links for each port are created in sysfs using the device
> name, but this could be changed after being added to the
> bridge.
>
> As well as being unable to remove interfaces after this
> occurs (because userspace tools don't recognise the new
> name, and the kernel won't recognise the old name), adding
> another interface with the old name to the bridge will
> cause an error trying to create the sysfs link.
>
> This fixes the problem by listening for NETDEV_CHANGENAME
> notifications and renaming the link.
>
> https://bugzilla.kernel.org/show_bug.cgi?id=12743
>
> Signed-off-by: Simon Arlott <simon@fire.lp0.eu>
> Acked-by: Stephen Hemminger <shemminger@vyatta.com>
Applied.
prev parent reply other threads:[~2010-05-16 6:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-10 19:31 [PATCH 0/4] bridge: patches for net-next Stephen Hemminger
2010-05-10 19:31 ` [PATCH 1/4] bridge: netpoll cleanup Stephen Hemminger
2010-05-16 6:12 ` David Miller
2010-05-10 19:31 ` [PATCH 2/4] bridge: change console message interface Stephen Hemminger
2010-05-16 6:12 ` David Miller
2010-05-10 19:31 ` [PATCH 3/4] bridge: netfilter use net_ratelimit Stephen Hemminger
2010-05-16 6:12 ` David Miller
2010-05-10 19:31 ` [PATCH 4/4] bridge: update sysfs link names if port device names have changed Stephen Hemminger
2010-05-16 6:12 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100515.231229.186295968.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bridge@lists.linux-foundation.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=simon@fire.lp0.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).