From: David Miller <davem@davemloft.net>
To: sebastian@breakpoint.cc
Cc: netdev@vger.kernel.org, tglx@linutronix.de
Subject: Re: [RFC 0/5] generic rx recycling
Date: Sat, 15 May 2010 23:32:45 -0700 (PDT) [thread overview]
Message-ID: <20100515.233245.90775757.davem@davemloft.net> (raw)
In-Reply-To: <1273070870-7821-1-git-send-email-sebastian@breakpoint.cc>
From: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
Date: Wed, 5 May 2010 16:47:45 +0200
> This series merges the rx recycling code trying to come up with generic
> code. Recycling skbs from the tx path for incomming rx skips the memory
> allocater and improves latency during memory pressure.
> This is now used by just by just four drivers in the tree which were doing
> this on their own.
You're adding new unnecessary SMP locking to all of these drivers.
In the gianfar original code the recycle queue is accessed lockless
using __skb_dequeue() et al. But you're using the skb_dequeue()
interface in the generic version which takes the SKB queue lock
which is absolutely unnecessary where these drivers make these
calls since they already need to have their chip RX path locked
already.
prev parent reply other threads:[~2010-05-16 6:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-05 14:47 [RFC 0/5] generic rx recycling Sebastian Andrzej Siewior
2010-05-05 14:47 ` [RFC 1/5] net: implement " Sebastian Andrzej Siewior
2010-05-05 14:47 ` [RFC 2/5] net/gianfar: use generic recycling infrasstructure Sebastian Andrzej Siewior
2010-05-05 14:47 ` [RFC 3/5] net/mv643xx: use generic recycling infrastructure Sebastian Andrzej Siewior
2010-05-05 14:47 ` [RFC 4/5] net/stmmac: " Sebastian Andrzej Siewior
2010-05-05 14:47 ` [RFC 5/5] net/ucc_geth: " Sebastian Andrzej Siewior
2010-05-16 6:32 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100515.233245.90775757.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sebastian@breakpoint.cc \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).