From: David Miller <davem@davemloft.net>
To: therbert@google.com
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next-2.6] net: Consistent skb timestamping
Date: Sat, 15 May 2010 23:56:35 -0700 (PDT) [thread overview]
Message-ID: <20100515.235635.63009445.davem@davemloft.net> (raw)
In-Reply-To: <AANLkTikLgHvtpCtBTKmJZBwixmZDHjRjGb1c59oAemli@mail.gmail.com>
From: Tom Herbert <therbert@google.com>
Date: Thu, 6 May 2010 08:12:57 -0700
> I'm contemplating changing SO_TIMESTAMP to not enable global
> timestamps, but only take the timestamp for a packet once the socket
> is identified and the timestamp flag is set (this is the technique
> done in FreeBSD and Solaris, so I believe the external semantics
> would still be valid).
This is not tenable.
Users have made it clear in the past that when they ask for a timestamp
they really want the timestamp as close to the device receive handling
path as possible.
Users basically really want timestamps in two places:
1) As near the device RX handling as possible
2) The point at which recvmsg() got the data
The former is obtainable from SO_TIMESTAMP and the latter from
gettimeofday().
So putting it way down to the point where we choose the socket isn't
going to work at all.
FreeBSD and Solaris combined have a tiny sliver of the number of users
we have to cater to, so they can have all kinds of latitude with which
to break things like that. So saying they do something is like saying
"the moon was out tonight", it has no relevance on whether we are able
to do it too :-)
The real fix is to make the devices less stupid and give us timestamps
directly, and thanks to things like PTP support in hardware that's
actually more and more of a reality these days.
next prev parent reply other threads:[~2010-05-16 6:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-06 12:01 [PATCH net-next-2.6] net: Consistent skb timestamping Eric Dumazet
2010-05-06 15:12 ` Tom Herbert
2010-05-06 15:37 ` Eric Dumazet
2010-05-06 16:14 ` Eric Dumazet
2010-05-16 6:57 ` David Miller
2010-05-16 6:56 ` David Miller [this message]
2010-05-16 18:30 ` Dimitris Michailidis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100515.235635.63009445.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).