Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: mchan@broadcom.com
Cc: sgruszka@redhat.com, netdev@vger.kernel.org
Subject: Re: [PATCH -next] bnx2: Use netif_carrier_off() to prevent timeout.
Date: Mon, 17 May 2010 17:34:56 -0700 (PDT)	[thread overview]
Message-ID: <20100517.173456.242125386.davem@davemloft.net> (raw)
In-Reply-To: <1273762115-13412-1-git-send-email-mchan@broadcom.com>

From: "Michael Chan" <mchan@broadcom.com>
Date: Thu, 13 May 2010 07:48:35 -0700

> Based on original patch from Stanislaw Gruszka <sgruszka@redhat.com>.
> 
> Using netif_carrier_off() is better than updating all the ->trans_start
> on all the tx queues.
> 
> netif_carrier_off() needs to be called after bnx2_disable_int_sync()
> to guarantee no race conditions with the serdes timers that can
> modify the carrier state.
> 
> If the chip or phy is reset, carrier will turn back on when we get the
> link interrupt.  If there is no reset, we need to turn carrier back on
> in bnx2_netif_start().  Again, the phy_lock prevents race conditions with
> the serdes timers.
> 
> Signed-off-by: Michael Chan <mchan@broadcom.com>
> Signed-off-by: Matt Carlson <mcarlson@broadcom.com>

Applied, thanks.

      reply	other threads:[~2010-05-18  0:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-13 14:48 [PATCH -next] bnx2: Use netif_carrier_off() to prevent timeout Michael Chan
2010-05-18  0:34 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100517.173456.242125386.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=mchan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=sgruszka@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox