From: David Miller <davem@davemloft.net>
To: socketcan@hartkopp.net
Cc: wg@grandegger.com, netdev@vger.kernel.org,
socketcan-core@lists.berlios.de
Subject: Re: [PATCH v2] Fix SJA1000 command register writes on SMP systems
Date: Mon, 17 May 2010 22:34:15 -0700 (PDT) [thread overview]
Message-ID: <20100517.223415.184853371.davem@davemloft.net> (raw)
In-Reply-To: <4BF1A464.6070207@hartkopp.net>
From: Oliver Hartkopp <socketcan@hartkopp.net>
Date: Mon, 17 May 2010 22:17:40 +0200
> diff --git a/drivers/net/can/sja1000/sja1000.c b/drivers/net/can/sja1000/sja1000.c
> index 145b1a7..2760085 100644
> --- a/drivers/net/can/sja1000/sja1000.c
> +++ b/drivers/net/can/sja1000/sja1000.c
> @@ -84,6 +84,27 @@ static struct can_bittiming_const sja1000_bittiming_const = {
> .brp_inc = 1,
> };
> +static void sja1000_write_cmdreg(struct sja1000_priv *priv, u8 val)
> +{
> + /* the command register needs some locking on SMP systems */
> +
> +#ifdef CONFIG_SMP
Something is adding spurious leading spaces to lines in your patch.
Also, please don't SMP conditionalize this code. It makes it such that
lock debugging et al. can't be used to check this code on uniprocessor.
next prev parent reply other threads:[~2010-05-18 5:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-17 20:17 [PATCH v2] Fix SJA1000 command register writes on SMP systems Oliver Hartkopp
2010-05-18 5:34 ` David Miller [this message]
[not found] ` <20100517.223415.184853371.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2010-05-18 18:56 ` Oliver Hartkopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100517.223415.184853371.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=socketcan-core@lists.berlios.de \
--cc=socketcan@hartkopp.net \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).