* [PATCH 14/20] drivers/net/vmxnet3: Use kzalloc
@ 2010-05-13 20:05 Julia Lawall
2010-05-13 21:20 ` [Pv-drivers] " Bhavesh Davda
2010-05-18 5:55 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Julia Lawall @ 2010-05-13 20:05 UTC (permalink / raw)
To: Shreyas Bhatewara, VMware, Inc., netdev, linux-kernel,
kernel-janitors
From: Julia Lawall <julia@diku.dk>
Use kzalloc rather than the combination of kmalloc and memset.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
expression x,size,flags;
statement S;
@@
-x = kmalloc(size,flags);
+x = kzalloc(size,flags);
if (x == NULL) S
-memset(x, 0, size);
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
drivers/net/vmxnet3/vmxnet3_drv.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff -u -p a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c
--- a/drivers/net/vmxnet3/vmxnet3_drv.c
+++ b/drivers/net/vmxnet3/vmxnet3_drv.c
@@ -1369,13 +1369,12 @@ vmxnet3_rq_create(struct vmxnet3_rx_queu
sz = sizeof(struct vmxnet3_rx_buf_info) * (rq->rx_ring[0].size +
rq->rx_ring[1].size);
- bi = kmalloc(sz, GFP_KERNEL);
+ bi = kzalloc(sz, GFP_KERNEL);
if (!bi) {
printk(KERN_ERR "%s: failed to allocate rx bufinfo\n",
adapter->netdev->name);
goto err;
}
- memset(bi, 0, sz);
rq->buf_info[0] = bi;
rq->buf_info[1] = bi + rq->rx_ring[0].size;
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [Pv-drivers] [PATCH 14/20] drivers/net/vmxnet3: Use kzalloc
2010-05-13 20:05 [PATCH 14/20] drivers/net/vmxnet3: Use kzalloc Julia Lawall
@ 2010-05-13 21:20 ` Bhavesh Davda
2010-05-18 5:55 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Bhavesh Davda @ 2010-05-13 21:20 UTC (permalink / raw)
To: Julia Lawall, Shreyas Bhatewara, VMware, Inc.,
netdev@vger.kernel.org, "linux-kernel@vger
Looks good. Thanks for doing this!
Signed-off-by: Bhavesh Davda <bhavesh@vmware.com>
- Bhavesh
Bhavesh P. Davda
> -----Original Message-----
> From: pv-drivers-bounces@vmware.com [mailto:pv-drivers-
> bounces@vmware.com] On Behalf Of Julia Lawall
> Sent: Thursday, May 13, 2010 1:06 PM
> To: Shreyas Bhatewara; VMware, Inc.; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org; kernel-janitors@vger.kernel.org
> Subject: [Pv-drivers] [PATCH 14/20] drivers/net/vmxnet3: Use kzalloc
>
> From: Julia Lawall <julia@diku.dk>
>
> Use kzalloc rather than the combination of kmalloc and memset.
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> expression x,size,flags;
> statement S;
> @@
>
> -x = kmalloc(size,flags);
> +x = kzalloc(size,flags);
> if (x == NULL) S
> -memset(x, 0, size);
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
>
> ---
> drivers/net/vmxnet3/vmxnet3_drv.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff -u -p a/drivers/net/vmxnet3/vmxnet3_drv.c
> b/drivers/net/vmxnet3/vmxnet3_drv.c
> --- a/drivers/net/vmxnet3/vmxnet3_drv.c
> +++ b/drivers/net/vmxnet3/vmxnet3_drv.c
> @@ -1369,13 +1369,12 @@ vmxnet3_rq_create(struct vmxnet3_rx_queu
>
> sz = sizeof(struct vmxnet3_rx_buf_info) * (rq->rx_ring[0].size +
> rq->rx_ring[1].size);
> - bi = kmalloc(sz, GFP_KERNEL);
> + bi = kzalloc(sz, GFP_KERNEL);
> if (!bi) {
> printk(KERN_ERR "%s: failed to allocate rx bufinfo\n",
> adapter->netdev->name);
> goto err;
> }
> - memset(bi, 0, sz);
> rq->buf_info[0] = bi;
> rq->buf_info[1] = bi + rq->rx_ring[0].size;
>
> _______________________________________________
> Pv-drivers mailing list
> Pv-drivers@vmware.com
> http://mailman2.vmware.com/mailman/listinfo/pv-drivers
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 14/20] drivers/net/vmxnet3: Use kzalloc
2010-05-13 20:05 [PATCH 14/20] drivers/net/vmxnet3: Use kzalloc Julia Lawall
2010-05-13 21:20 ` [Pv-drivers] " Bhavesh Davda
@ 2010-05-18 5:55 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2010-05-18 5:55 UTC (permalink / raw)
To: julia; +Cc: sbhatewara, pv-drivers, netdev, linux-kernel, kernel-janitors
From: Julia Lawall <julia@diku.dk>
Date: Thu, 13 May 2010 22:05:40 +0200 (CEST)
> From: Julia Lawall <julia@diku.dk>
>
> Use kzalloc rather than the combination of kmalloc and memset.
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> expression x,size,flags;
> statement S;
> @@
>
> -x = kmalloc(size,flags);
> +x = kzalloc(size,flags);
> if (x == NULL) S
> -memset(x, 0, size);
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-05-18 5:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-13 20:05 [PATCH 14/20] drivers/net/vmxnet3: Use kzalloc Julia Lawall
2010-05-13 21:20 ` [Pv-drivers] " Bhavesh Davda
2010-05-18 5:55 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).