From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: tcp md5 fraglist...
Date: Mon, 17 May 2010 23:35:37 -0700 (PDT) [thread overview]
Message-ID: <20100517.233537.62328306.davem@davemloft.net> (raw)
In-Reply-To: <1274164224.2567.35.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 18 May 2010 08:30:24 +0200
> Le lundi 17 mai 2010 à 23:14 -0700, David Miller a écrit :
>> Eric, would you please formally submit that tcp md5 fraglist
>> fix to net/ipv4/tcp.c with proper signoffs?
>>
>> Thanks!
>
> Sure, will do, but I doubt it is a real problem, because GRO or RSC
> should not coalesce two segments with MD5 signature (they are guaranteed
> to differ for each segment ?)
Right, and I just checked that GRO does in fact check if the TCP
options are different in any way.
next prev parent reply other threads:[~2010-05-18 6:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-18 6:14 tcp md5 fraglist David Miller
2010-05-18 6:30 ` Eric Dumazet
2010-05-18 6:35 ` David Miller [this message]
2010-05-18 6:40 ` [PATCH] tcp: tcp_md5_hash_skb_data() frag_list handling Eric Dumazet
2010-05-31 7:30 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100517.233537.62328306.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).