From: "Michael S. Tsirkin" <mst@redhat.com>
To: Tobias Klauser <tklauser@distanz.ch>
Cc: kvm@vger.kernel.org, virtualization@lists.osdl.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] vhost: Storage class should be before const qualifier
Date: Mon, 17 May 2010 16:13:35 +0300 [thread overview]
Message-ID: <20100517131335.GA12126@redhat.com> (raw)
In-Reply-To: <1274101969-21109-1-git-send-email-tklauser@distanz.ch>
On Mon, May 17, 2010 at 03:12:49PM +0200, Tobias Klauser wrote:
> The C99 specification states in section 6.11.5:
>
> The placement of a storage-class specifier other than at the beginning
> of the declaration specifiers in a declaration is an obsolescent
> feature.
>
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Will apply, thanks!
Just to clarify: does some compiler/checker actually barf on this?
> ---
> drivers/vhost/net.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c
> index aa88911..cd36f5f 100644
> --- a/drivers/vhost/net.c
> +++ b/drivers/vhost/net.c
> @@ -626,7 +626,7 @@ static long vhost_net_compat_ioctl(struct file *f, unsigned int ioctl,
> }
> #endif
>
> -const static struct file_operations vhost_net_fops = {
> +static const struct file_operations vhost_net_fops = {
> .owner = THIS_MODULE,
> .release = vhost_net_release,
> .unlocked_ioctl = vhost_net_ioctl,
> --
> 1.6.3.3
next prev parent reply other threads:[~2010-05-17 13:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-17 13:12 [PATCH] vhost: Storage class should be before const qualifier Tobias Klauser
2010-05-17 13:13 ` Michael S. Tsirkin [this message]
2010-05-17 13:27 ` Tobias Klauser
2010-05-17 13:54 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100517131335.GA12126@redhat.com \
--to=mst@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tklauser@distanz.ch \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox