Re: [patch] pm_qos update fixing mmotm 2010-05-11 -dies in pm_qos_update_request()

["Rafael J. Wysocki" <rjw@sisk.pl>]

On Monday 17 May 2010, mgross wrote:
> On Mon, May 17, 2010 at 12:21:25AM +0200, Rafael J. Wysocki wrote:
> > On Saturday 15 May 2010, mgross wrote:
> > > On Sat, May 15, 2010 at 09:38:47PM +0200, Rafael J. Wysocki wrote:
> > > > On Saturday 15 May 2010, mgross wrote:
> > > > > I apologize for the goofy email address.  
> > > > > 
> > > > > The following is a fix for the crash reported by Valdis.
> > > > > 
> > > > > The problem was that the original pm_qos silently fails when a request
> > > > > update is passed to a parameter that has not been added to the list
> > > > > yet.  It seems that the e1000e is doing this.  This update restores this
> > > > > behavior.
> > > > > 
> > > > > I need to think about how to better handle such abuse, but for now this
> > > > > restores the original behavior.
> > > > 
> > > > Can you please post a signed-off incremental patch against
> > > > 
> > > > git://git.kernel.org/pub/scm/linux/kernel/git/rafael/suspend-2.6.git for-llinus
> > > > 
> > > > that contains your original PM QOS update?
> > > 
> > > No problem:
> > >
> > > Signed-off-by: markgross <markgross@thegnar.org>
> > 
> > Thanks!  Do you want to use this address for the sign-off or the Intel one?
> 
> I guess so.  Ever since switching groups within intel last summer my
> mgross@linux.intel.com address isn't checked as often as this one. 
> 
> The other option is to use my outlook email (mark.gross@intel.com), but
> I really hate posting from outlook.  Besides, doing upstream kernel
> stuff isn't my day job any more so using markgross@thegnar.org  makes
> sense to me.

Good.  Patch applied to suspend-2.6/for-linus.

Thanks,
Rafael

------------------------------------------------------------------------------

_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel&#174; Ethernet, visit http://communities.intel.com/community/wired