From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jes Sorensen <Jes.Sorensen@redhat.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
Jiri Pirko <jpirko@redhat.com>, Shirley Ma <xma@us.ibm.com>,
Amit Shah <amit.shah@redhat.com>,
Mark McLoughlin <markmc@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
quintela@redhat.com, alex.williamson@redhat.com
Subject: Re: [PATCH] virtio: put last seen used index into ring itself
Date: Tue, 18 May 2010 13:25:45 +0300 [thread overview]
Message-ID: <20100518102545.GA26338@redhat.com> (raw)
In-Reply-To: <4BF26B87.3080902@redhat.com>
On Tue, May 18, 2010 at 12:27:19PM +0200, Jes Sorensen wrote:
> On 05/18/10 02:47, Michael S. Tsirkin wrote:
> > Generally, the Host end of the virtio ring doesn't need to see where
> > Guest is up to in consuming the ring. However, to completely understand
> > what's going on from the outside, this information must be exposed.
> > For example, host can reduce the number of interrupts by detecting
> > that the guest is currently handling previous buffers.
> >
> > Fortunately, we have room to expand: the ring is always a whole number
> > of pages and there's hundreds of bytes of padding after the avail ring
> > and the used ring, whatever the number of descriptors (which must be a
> > power of 2).
>
> Hi Michael,
>
> Small build fix for this against Linus upstream.
>
> Jes
>
>
> Fix build of virtio_net.c
>
> Signed-off-by: Jes.Sorensen@redhat.com
Thanks, this is already fixed in v2 that I sent.
> ---
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index d37e5be..679e2df 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -23,6 +23,7 @@
> #include <linux/module.h>
> #include <linux/virtio.h>
> #include <linux/virtio_net.h>
> +#include <linux/virtio_ring.h>
> #include <linux/scatterlist.h>
> #include <linux/if_vlan.h>
> #include <linux/slab.h>
>
prev parent reply other threads:[~2010-05-18 10:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-18 0:47 [PATCH] virtio: put last seen used index into ring itself Michael S. Tsirkin
2010-05-18 7:41 ` Rusty Russell
2010-05-18 10:27 ` Jes Sorensen
2010-05-18 10:25 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100518102545.GA26338@redhat.com \
--to=mst@redhat.com \
--cc=Jes.Sorensen@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=amit.shah@redhat.com \
--cc=jpirko@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markmc@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=quintela@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=xma@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).