From: David Miller <davem@davemloft.net>
To: sonic.adi@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 06/11] netdev: bfin_mac: avoid tx skb overflows in the tx DMA ring
Date: Wed, 19 May 2010 13:12:19 -0700 (PDT) [thread overview]
Message-ID: <20100519.131219.172592870.davem@davemloft.net> (raw)
In-Reply-To: <AANLkTikKz6v09VTjtANmmcGHU1eKcVWjuDIO24KqkHWK@mail.gmail.com>
From: Sonic Zhang <sonic.adi@gmail.com>
Date: Wed, 19 May 2010 17:23:16 +0800
> No, this doesn't happen, because before ndo_start_xmit() returns, the
> old TX buffers and skbs in the ring, which finished DMA operation, are
> freed. The only difference is that the free operation of a skb is done
> in next tx transfer.
This is still illegal.
What if TX activity stops right then, and there is no "next tx
transfer"?
That SKB will never get freed, ever.
You have to fix this.
next prev parent reply other threads:[~2010-05-19 20:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-09 10:18 [PATCH 01/11] netdev: bfin_mac: add support for IEEE 1588 PTP Mike Frysinger
2010-05-09 10:18 ` [PATCH 02/11] netdev: bfin_mac: handler RX status errors Mike Frysinger
2010-05-09 10:18 ` [PATCH 03/11] netdev: bfin_mac: invalid data cache only once for each new rx skb buffer Mike Frysinger
[not found] ` <1273400337-26501-1-git-send-email-vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
2010-05-09 10:18 ` [PATCH 04/11] netdev: bfin_mac: deduce Ethernet FCS from hardware IP payload checksum Mike Frysinger
2010-05-09 10:18 ` [PATCH 05/11] netdev: bfin_mac: clear RXCKS if hardware generated checksum is not enabled Mike Frysinger
2010-05-09 10:18 ` [PATCH 06/11] netdev: bfin_mac: avoid tx skb overflows in the tx DMA ring Mike Frysinger
2010-05-10 11:40 ` David Miller
[not found] ` <AANLkTimWjjXKwi_YLFPxBrCBu1qkiuaUKyo1UW5373lH@mail.gmail.com>
2010-05-18 19:29 ` David Miller
2010-05-19 9:23 ` Sonic Zhang
2010-05-19 20:12 ` David Miller [this message]
[not found] ` <AANLkTimDFWyO8YaNJrWifkYS6g6zSvMZXmtEniCO1wb1@mail.gmail.com>
[not found] ` <20100520.030835.267363374.davem@davemloft.net>
2010-05-20 10:23 ` Sonic Zhang
2010-05-20 10:36 ` Sonic Zhang
2010-05-09 10:18 ` [PATCH 07/11] netdev: bfin_mac: add support for wake-on-lan magic packets Mike Frysinger
2010-05-09 10:18 ` [PATCH 08/11] netdev: bfin_mac: use promiscuous flag for promiscuous mode Mike Frysinger
2010-05-09 10:18 ` [PATCH 09/11] netdev: bfin_mac: only use hardware checksum in normal IPv4 mode Mike Frysinger
2010-05-10 11:42 ` David Miller
2010-05-10 15:35 ` [Uclinux-dist-devel] " Mike Frysinger
2010-05-09 10:18 ` [PATCH 10/11] netdev: bfin_mac: handle timeouts with the MDIO registers gracefully Mike Frysinger
2010-05-09 10:18 ` [PATCH 11/11] netdev: bfin_mac: check for mii_bus platform data Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100519.131219.172592870.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sonic.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).