netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 2/2] net: Add classid to sk_buff.
@ 2010-05-20  2:55 David Miller
  2010-05-20  3:36 ` Herbert Xu
  0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2010-05-20  2:55 UTC (permalink / raw)
  To: bmb; +Cc: tgraf, nhorman, nhorman, eric.dumazet, herbert, netdev


We make this zero cost by moving queue_mapping into an existing
empty __u16 slot.  Thus making a __u32 available, which we use
for the 'classid'.

Signed-off-by: David S. Miller <davem@davemloft.net>
---
 include/linux/skbuff.h |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index 7c16f24..f847ec2 100644
--- a/include/linux/skbuff.h
+++ b/include/linux/skbuff.h
@@ -367,12 +367,9 @@ struct sk_buff {
 #ifdef CONFIG_NET_CLS_ACT
 	__u16			tc_verd;	/* traffic control verdict */
 #endif
+	__u32			classid;
 #endif
 
-	__u16			queue_mapping;
-
-	/* 16 bit hole */
-
 #ifdef CONFIG_NET_DMA
 	dma_cookie_t		dma_cookie;
 #endif
@@ -385,6 +382,7 @@ struct sk_buff {
 	};
 
 	__u16			vlan_tci;
+	__u16			queue_mapping;
 
 	sk_buff_data_t		transport_header;
 	sk_buff_data_t		network_header;
-- 
1.7.0.4


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 2/2] net: Add classid to sk_buff.
  2010-05-20  2:55 [PATCH 2/2] net: Add classid to sk_buff David Miller
@ 2010-05-20  3:36 ` Herbert Xu
  2010-05-20  3:47   ` David Miller
  0 siblings, 1 reply; 3+ messages in thread
From: Herbert Xu @ 2010-05-20  3:36 UTC (permalink / raw)
  To: David Miller; +Cc: bmb, tgraf, nhorman, nhorman, eric.dumazet, netdev

On Wed, May 19, 2010 at 07:55:38PM -0700, David Miller wrote:
> 
> We make this zero cost by moving queue_mapping into an existing
> empty __u16 slot.  Thus making a __u32 available, which we use
> for the 'classid'.
> 
> Signed-off-by: David S. Miller <davem@davemloft.net>

You better hide this space before someone steals it :)
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 2/2] net: Add classid to sk_buff.
  2010-05-20  3:36 ` Herbert Xu
@ 2010-05-20  3:47   ` David Miller
  0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2010-05-20  3:47 UTC (permalink / raw)
  To: herbert; +Cc: bmb, tgraf, nhorman, nhorman, eric.dumazet, netdev

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Thu, 20 May 2010 13:36:43 +1000

> On Wed, May 19, 2010 at 07:55:38PM -0700, David Miller wrote:
>> 
>> We make this zero cost by moving queue_mapping into an existing
>> empty __u16 slot.  Thus making a __u32 available, which we use
>> for the 'classid'.
>> 
>> Signed-off-by: David S. Miller <davem@davemloft.net>
> 
> You better hide this space before someone steals it :)

Indeed, I didn't even know we had it to begin with. :)

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-05-20  3:46 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-20  2:55 [PATCH 2/2] net: Add classid to sk_buff David Miller
2010-05-20  3:36 ` Herbert Xu
2010-05-20  3:47   ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).