netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Denys Fedorysychenko <nuclearcat@nuclearcat.com>
To: Patrick McHardy <kaber@trash.net>
Cc: netdev@vger.kernel.org, Jeff Garzik <jeff@garzik.org>,
	Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: HFSC classes going out of bounds, regression in recent kernels?
Date: Thu, 20 May 2010 04:34:27 +0300	[thread overview]
Message-ID: <201005200434.28433.nuclearcat@nuclearcat.com> (raw)
In-Reply-To: <4BBB5543.40607@trash.net>

I am trying to track down HFSC bug.
It seems, most probably it is related to PSCHED_SHIFT at the end, i am doing 
testing again. I will try to do complete clean build, maybe last time some .o 
was left or i forgot to do make clean.

SM_SHIFT in HFSC is calculated as 30 - PSCHED_SHIFT, and it is shifted too 
much (or not enough) with new changes (ISM_SHIFT seems wrong too). So it is 
most probably overflow or not enough resolution.
I will try to change PSCHED_SHIFT back to confirm that, and at least i found 
way to reproduce bug.

Additionally in sch_hfsc.c i notice mentioned that PSCHED_SHIFT 10 is tick per 
1024us, but i try to calculate their table (in source comments), it doesn't 
fit with my calculations based on 1024us/tick, but fits well with 1024 
nanosecond.

Is it was 1024ns per tick and now 64ns per tick? Or it is microseconds(us) ?

  parent reply	other threads:[~2010-05-20  1:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-06 15:22 HFSC classes going out of bounds, regression in recent kernels? Denys Fedorysychenko
2010-04-06 15:37 ` Patrick McHardy
2010-04-06 15:45   ` Denys Fedorysychenko
2010-04-11  2:10   ` Denys Fedorysychenko
2010-05-20  1:34   ` Denys Fedorysychenko [this message]
2010-05-31 17:53     ` Michal Soltys

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201005200434.28433.nuclearcat@nuclearcat.com \
    --to=nuclearcat@nuclearcat.com \
    --cc=eric.dumazet@gmail.com \
    --cc=jeff@garzik.org \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).