* [PATCH] sh_eth: Fix memleak in sh_mdio_release
@ 2010-05-20 14:00 Denis Kirjanov
2010-05-20 22:12 ` Nobuhiro Iwamatsu
0 siblings, 1 reply; 3+ messages in thread
From: Denis Kirjanov @ 2010-05-20 14:00 UTC (permalink / raw)
To: davem; +Cc: shimoda.yoshihiro, iwamatsu, morimoto.kuninori, netdev
Allocated memory for IRQs should be freed when releasing the mii_bus
Signed-off-by: Denis Kirjanov <dkirjanov@kernel.org>
---
drivers/net/sh_eth.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/net/sh_eth.c b/drivers/net/sh_eth.c
index 586ed09..501a55f 100644
--- a/drivers/net/sh_eth.c
+++ b/drivers/net/sh_eth.c
@@ -1294,6 +1294,9 @@ static int sh_mdio_release(struct net_device *ndev)
/* remove mdio bus info from net_device */
dev_set_drvdata(&ndev->dev, NULL);
+ /* free interrupts memory */
+ kfree(bus->irq);
+
/* free bitbang info */
free_mdio_bitbang(bus);
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] sh_eth: Fix memleak in sh_mdio_release
2010-05-20 14:00 [PATCH] sh_eth: Fix memleak in sh_mdio_release Denis Kirjanov
@ 2010-05-20 22:12 ` Nobuhiro Iwamatsu
2010-05-21 6:14 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Nobuhiro Iwamatsu @ 2010-05-20 22:12 UTC (permalink / raw)
To: Denis Kirjanov; +Cc: davem, shimoda.yoshihiro, morimoto.kuninori, netdev
Hi, Denis.
2010/5/20 Denis Kirjanov <dkirjanov@hera.kernel.org>:
> Allocated memory for IRQs should be freed when releasing the mii_bus
>
> Signed-off-by: Denis Kirjanov <dkirjanov@kernel.org>
> ---
>
> drivers/net/sh_eth.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/sh_eth.c b/drivers/net/sh_eth.c
> index 586ed09..501a55f 100644
> --- a/drivers/net/sh_eth.c
> +++ b/drivers/net/sh_eth.c
> @@ -1294,6 +1294,9 @@ static int sh_mdio_release(struct net_device *ndev)
> /* remove mdio bus info from net_device */
> dev_set_drvdata(&ndev->dev, NULL);
>
> + /* free interrupts memory */
> + kfree(bus->irq);
> +
> /* free bitbang info */
> free_mdio_bitbang(bus);
>
>
Acked-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
Thanks!
Best regards,
Nobuhiro
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] sh_eth: Fix memleak in sh_mdio_release
2010-05-20 22:12 ` Nobuhiro Iwamatsu
@ 2010-05-21 6:14 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2010-05-21 6:14 UTC (permalink / raw)
To: iwamatsu; +Cc: dkirjanov, shimoda.yoshihiro, morimoto.kuninori, netdev
From: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
Date: Fri, 21 May 2010 07:12:21 +0900
> 2010/5/20 Denis Kirjanov <dkirjanov@hera.kernel.org>:
>> Allocated memory for IRQs should be freed when releasing the mii_bus
>>
>> Signed-off-by: Denis Kirjanov <dkirjanov@kernel.org>
...
> Acked-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
Applied, thanks everyone.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-05-21 6:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-20 14:00 [PATCH] sh_eth: Fix memleak in sh_mdio_release Denis Kirjanov
2010-05-20 22:12 ` Nobuhiro Iwamatsu
2010-05-21 6:14 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).