From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: therbert@google.com, xiaosuo@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH v2] net: fix problem in dequeuing from input_pkt_queue
Date: Fri, 21 May 2010 00:38:41 -0700 (PDT) [thread overview]
Message-ID: <20100521.003841.82805563.davem@davemloft.net> (raw)
In-Reply-To: <1274424946.2439.7.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Fri, 21 May 2010 08:55:46 +0200
> Le jeudi 20 mai 2010 à 21:37 -0700, Tom Herbert a écrit :
>> Fix some issues introduced in batch skb dequeuing for input_pkt_queue.
>> The primary issue it that the queue head must be incremented only
>> after a packet has been processed, that is only after
>> __netif_receive_skb has been called. This is needed for the mechanism
>> to prevent OOO packet in RFS. Also when flushing the input_pkt_queue
>> and process_queue, the process queue should be done first to prevent
>> OOO packets.
>>
>> Because the input_pkt_queue has been effectively split into two queues,
>> the calculation of the tail ptr is no longer correct. The correct value
>> would be head+input_pkt_queue->len+process_queue->len. To avoid
>> this calculation we added an explict input_queue_tail in softnet_data.
>> The tail value is simply incremented when queuing to input_pkt_queue.
>>
>> Signed-off-by: Tom Herbert <therbert@google.com>
>> ---
>
> Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied, thanks everyone.
prev parent reply other threads:[~2010-05-21 7:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-21 4:37 [PATCH v2] net: fix problem in dequeuing from input_pkt_queue Tom Herbert
2010-05-21 6:55 ` Eric Dumazet
2010-05-21 7:38 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100521.003841.82805563.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).