From: Dan Carpenter <error27@gmail.com>
To: timo.teras@iki.fi
Cc: netdev@vger.kernel.org
Subject: bug report: xfrm: potential null deref in xfrm_bundle_lookup()
Date: Sat, 22 May 2010 22:24:30 +0200 [thread overview]
Message-ID: <20100522202430.GN22515@bicker> (raw)
This is a smatch thing. I couldn't tell if it was a real issue so I
thought I would send this mail to the experts. :)
net/xfrm/xfrm_policy.c +1679 xfrm_bundle_lookup(51)
error: we previously assumed 'xdst' could be null.
1672 new_xdst = xfrm_resolve_and_create_bundle(pols, num_pols, fl, family, dst_orig);
1673 if (IS_ERR(new_xdst)) {
1674 err = PTR_ERR(new_xdst);
1675 if (err != -EAGAIN)
1676 goto error;
1677 if (oldflo == NULL)
1678 goto make_dummy_bundle;
1679 dst_hold(&xdst->u.dst);
^^^^^^^^^^^
Can xdst be NULL here? It would have to be something like
oldflo gets passed in as null and __xfrm_policy_lookup() fails.
1680 return oldflo;
1681 }
regards,
dan carpenter
next reply other threads:[~2010-05-22 20:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-22 20:24 Dan Carpenter [this message]
2010-05-23 18:06 ` bug report: xfrm: potential null deref in xfrm_bundle_lookup() Timo Teräs
2010-05-23 19:38 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100522202430.GN22515@bicker \
--to=error27@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=timo.teras@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).