From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: hadi@cyberus.ca, kaber@trash.net, blp@nicira.com, netdev@vger.kernel.org
Subject: Re: [PATCH] net_sched: Fix qdisc_notify()
Date: Sun, 23 May 2010 23:11:52 -0700 (PDT) [thread overview]
Message-ID: <20100523.231152.116127631.davem@davemloft.net> (raw)
In-Reply-To: <1274596664.5020.40.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Sun, 23 May 2010 08:37:44 +0200
> [PATCH] net_sched: Fix qdisc_notify()
>
> Ben Pfaff reported a kernel oops and provided a test program to
> reproduce it.
>
> https://kerneltrap.org/mailarchive/linux-netdev/2010/5/21/6277805
>
> tc_fill_qdisc() should not be called for builtin qdisc, or it
> dereference a NULL pointer to get device ifindex.
>
> Fix is to always use tc_qdisc_dump_ignore() before calling
> tc_fill_qdisc().
>
> Reported-by: Ben Pfaff <blp@nicira.com>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied and queued up for -stable.
prev parent reply other threads:[~2010-05-24 6:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-21 22:42 tc: RTM_GETQDISC causes kernel OOPS Ben Pfaff
2010-05-22 7:18 ` Eric Dumazet
2010-05-22 9:51 ` Patrick McHardy
2010-05-22 12:31 ` jamal
2010-05-23 6:37 ` [PATCH] net_sched: Fix qdisc_notify() Eric Dumazet
2010-05-24 6:11 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100523.231152.116127631.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=blp@nicira.com \
--cc=eric.dumazet@gmail.com \
--cc=hadi@cyberus.ca \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).