From: David Miller <davem@davemloft.net>
To: Ian.Campbell@citrix.com
Cc: netdev@vger.kernel.org, shemminger@linux-foundation.org,
jeremy.fitzhardinge@citrix.com, stable@kernel.org
Subject: Re: [PATCH 0/2] fixes to arp_notify for virtual machine migration use case
Date: Sun, 23 May 2010 23:37:22 -0700 (PDT) [thread overview]
Message-ID: <20100523.233722.232536798.davem@davemloft.net> (raw)
In-Reply-To: <1273671554.7572.11190.camel@zakaz.uk.xensource.com>
From: Ian Campbell <Ian.Campbell@citrix.com>
Date: Wed, 12 May 2010 14:39:14 +0100
> Ian Campbell (2):
> arp_notify: generate broadcast ARP reply not request.
> arp_notify: generate arp_notify event on NETDEV_CHANGE too
I don't agree with these changes.
For the first one, I think the documentation is just wrong and the
code is what expresses the intent. The idea is not to spam the
world with a broadcast, only interested parties.
Patch #2 I have major issues with, carriers flapping occaisionally is
very common. I have several interfaces which do this even on lightly
loaded networks. Iff we decide to do something like this (big "if")
it would need to be rate limited so that it doesn't trigger due to
normal flapping.
If you want your VM networking devices to trigger this event maybe
the best thing to do is to create a special notification which
allows us to prevent from doing this ARP notify for spurious physical
network device carrier flaps.
next prev parent reply other threads:[~2010-05-24 6:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-12 13:39 [PATCH 0/2] fixes to arp_notify for virtual machine migration use case Ian Campbell
2010-05-12 13:40 ` [PATCH] arp_notify: generate broadcast ARP reply not request Ian Campbell
2010-05-12 13:40 ` [PATCH] arp_notify: generate arp_notify event on NETDEV_CHANGE too Ian Campbell
2010-05-24 6:37 ` David Miller [this message]
2010-05-25 9:20 ` [PATCH 0/2] fixes to arp_notify for virtual machine migration use case Ian Campbell
2010-05-26 6:08 ` David Miller
2010-05-26 10:08 ` Ian Campbell
2010-05-26 10:09 ` [PATCH 1/3] arp_notify: document that a gratuitous ARP request is sent when this option is enabled Ian Campbell
2010-05-26 10:09 ` [PATCH 2/3] arp_notify: allow drivers to explicitly request a notification event Ian Campbell
2010-05-26 10:09 ` [PATCH 3/3] xen: netfront: explicitly generate arp_notify event after migration Ian Campbell
2010-05-31 7:32 ` [PATCH 0/2] fixes to arp_notify for virtual machine migration use case David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100523.233722.232536798.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Ian.Campbell@citrix.com \
--cc=jeremy.fitzhardinge@citrix.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).