* [PATCH] net/irda: bfin_sir: IRDA is not affected by anomaly 05000230
@ 2010-05-23 8:00 Mike Frysinger
2010-05-24 6:54 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Mike Frysinger @ 2010-05-23 8:00 UTC (permalink / raw)
To: netdev, David S. Miller; +Cc: uclinux-dist-devel, Graf Yang
From: Graf Yang <graf.yang@analog.com>
Anomaly 05000230 (over sampling of the UART STOP bit) applies only when
the peripheral is operating in UART mode. So drop the anomaly handling
in the IRDA code.
Signed-off-by: Graf Yang <graf.yang@analog.com>
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
Note: this is fine for 2.6.35 or 2.6.36
drivers/net/irda/bfin_sir.c | 8 ++++++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/net/irda/bfin_sir.c b/drivers/net/irda/bfin_sir.c
index 911c082..f940dfa 100644
--- a/drivers/net/irda/bfin_sir.c
+++ b/drivers/net/irda/bfin_sir.c
@@ -107,8 +107,12 @@ static int bfin_sir_set_speed(struct bfin_sir_port *port, int speed)
case 57600:
case 115200:
- quot = (port->clk + (8 * speed)) / (16 * speed)\
- - ANOMALY_05000230;
+ /*
+ * IRDA is not affected by anomaly 05000230, so there is no
+ * need to tweak the divisor like he UART driver (which will
+ * slightly speed up the baud rate on us).
+ */
+ quot = (port->clk + (8 * speed)) / (16 * speed);
do {
udelay(utime);
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net/irda: bfin_sir: IRDA is not affected by anomaly 05000230
2010-05-23 8:00 [PATCH] net/irda: bfin_sir: IRDA is not affected by anomaly 05000230 Mike Frysinger
@ 2010-05-24 6:54 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-05-24 6:54 UTC (permalink / raw)
To: vapier; +Cc: netdev, uclinux-dist-devel, graf.yang
From: Mike Frysinger <vapier@gentoo.org>
Date: Sun, 23 May 2010 04:00:10 -0400
> From: Graf Yang <graf.yang@analog.com>
>
> Anomaly 05000230 (over sampling of the UART STOP bit) applies only when
> the peripheral is operating in UART mode. So drop the anomaly handling
> in the IRDA code.
>
> Signed-off-by: Graf Yang <graf.yang@analog.com>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-05-24 6:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-23 8:00 [PATCH] net/irda: bfin_sir: IRDA is not affected by anomaly 05000230 Mike Frysinger
2010-05-24 6:54 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).