From: David Miller <davem@davemloft.net>
To: bmb@athenacr.com
Cc: tgraf@redhat.com, nhorman@tuxdriver.com, nhorman@redhat.com,
eric.dumazet@gmail.com, herbert@gondor.hengli.com.au,
netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] ipv6: Store ndisc_nodeid in IP6CB().
Date: Sun, 23 May 2010 23:58:58 -0700 (PDT) [thread overview]
Message-ID: <20100523.235858.262775026.davem@davemloft.net> (raw)
In-Reply-To: <20100519.195536.32704411.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Wed, 19 May 2010 19:55:36 -0700 (PDT)
>
> There is no reason we need to use up space in the generic
> SKB area for this. All packet input paths in ipv6 explicitly
> clear out the IP6CB() area and therefore the default value
> for ndisc_nodeid will be correct.
>
> Signed-off-by: David S. Miller <davem@davemloft.net>
Turns out the patch doesn't build, because it throws the
DCCP control block beyond the skb->cb[] size of 48 bytes
with ipv6 enabled on 64-bit.
Ho hum...
prev parent reply other threads:[~2010-05-24 6:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-20 2:55 [PATCH 1/2] ipv6: Store ndisc_nodeid in IP6CB() David Miller
2010-05-20 3:35 ` Herbert Xu
2010-05-24 6:58 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100523.235858.262775026.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bmb@athenacr.com \
--cc=eric.dumazet@gmail.com \
--cc=herbert@gondor.hengli.com.au \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=nhorman@tuxdriver.com \
--cc=tgraf@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).