* net/dccp: expansion of error code size
@ 2010-05-24 6:45 Yoichi Yuasa
2010-05-25 1:37 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Yoichi Yuasa @ 2010-05-24 6:45 UTC (permalink / raw)
To: David S. Miller; +Cc: yuasa, linux-mips, netdev
Because MIPS's EDQUOT value is 1133(0x46d).
It's larger than u8.
Signed-off-by: Yoichi Yuasa <yuasa@linux-mips.org>
---
net/dccp/input.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/net/dccp/input.c b/net/dccp/input.c
index 58f7bc1..6beb6a7 100644
--- a/net/dccp/input.c
+++ b/net/dccp/input.c
@@ -124,9 +124,9 @@ static int dccp_rcv_closereq(struct sock *sk, struct sk_buff *skb)
return queued;
}
-static u8 dccp_reset_code_convert(const u8 code)
+static u16 dccp_reset_code_convert(const u8 code)
{
- const u8 error_code[] = {
+ const u16 error_code[] = {
[DCCP_RESET_CODE_CLOSED] = 0, /* normal termination */
[DCCP_RESET_CODE_UNSPECIFIED] = 0, /* nothing known */
[DCCP_RESET_CODE_ABORTED] = ECONNRESET,
@@ -148,7 +148,7 @@ static u8 dccp_reset_code_convert(const u8 code)
static void dccp_rcv_reset(struct sock *sk, struct sk_buff *skb)
{
- u8 err = dccp_reset_code_convert(dccp_hdr_reset(skb)->dccph_reset_code);
+ u16 err = dccp_reset_code_convert(dccp_hdr_reset(skb)->dccph_reset_code);
sk->sk_err = err;
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: net/dccp: expansion of error code size
2010-05-24 6:45 net/dccp: expansion of error code size Yoichi Yuasa
@ 2010-05-25 1:37 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-05-25 1:37 UTC (permalink / raw)
To: yuasa; +Cc: linux-mips, netdev
From: Yoichi Yuasa <yuasa@linux-mips.org>
Date: Mon, 24 May 2010 15:45:08 +0900
> Because MIPS's EDQUOT value is 1133(0x46d).
> It's larger than u8.
>
> Signed-off-by: Yoichi Yuasa <yuasa@linux-mips.org>
Applied, thank you.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-05-25 1:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-24 6:45 net/dccp: expansion of error code size Yoichi Yuasa
2010-05-25 1:37 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).