* [PATCH net-2.6] be2net: Bug fix in init code in probe
@ 2010-05-24 11:20 Sarveshwar Bandi
2010-05-25 1:39 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Sarveshwar Bandi @ 2010-05-24 11:20 UTC (permalink / raw)
To: netdev; +Cc: davem
PCI function reset needs to invoked after fw init ioctl is issued.
Signed-off-by: Sarveshwar Bandi <sarveshwarb@serverengines.com>
---
drivers/net/benet/be_main.c | 10 ++++++----
1 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/net/benet/be_main.c b/drivers/net/benet/be_main.c
index 058d7f9..1c79c20 100644
--- a/drivers/net/benet/be_main.c
+++ b/drivers/net/benet/be_main.c
@@ -2487,10 +2487,6 @@ static int __devinit be_probe(struct pci
status = be_cmd_POST(adapter);
if (status)
goto ctrl_clean;
-
- status = be_cmd_reset_function(adapter);
- if (status)
- goto ctrl_clean;
}
/* tell fw we're ready to fire cmds */
@@ -2498,6 +2494,12 @@ static int __devinit be_probe(struct pci
if (status)
goto ctrl_clean;
+ if (be_physfn(adapter)) {
+ status = be_cmd_reset_function(adapter);
+ if (status)
+ goto ctrl_clean;
+ }
+
status = be_stats_init(adapter);
if (status)
goto ctrl_clean;
--
1.4.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-2.6] be2net: Bug fix in init code in probe
2010-05-24 11:20 [PATCH net-2.6] be2net: Bug fix in init code in probe Sarveshwar Bandi
@ 2010-05-25 1:39 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2010-05-25 1:39 UTC (permalink / raw)
To: sarveshwarb; +Cc: netdev
From: Sarveshwar Bandi <sarveshwarb@serverengines.com>
Date: Mon, 24 May 2010 16:50:47 +0530
> PCI function reset needs to invoked after fw init ioctl is issued.
>
> Signed-off-by: Sarveshwar Bandi <sarveshwarb@serverengines.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-05-25 1:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-24 11:20 [PATCH net-2.6] be2net: Bug fix in init code in probe Sarveshwar Bandi
2010-05-25 1:39 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).