netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: "Brandeburg, Jesse" <jesse.brandeburg@intel.com>
Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"stable@kernel.org" <stable@kernel.org>,
	Brandon <brandon@ifup.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [stable] [stable-2.6.32 PATCH] ixgbe: backport bug fix for tx panic
Date: Tue, 25 May 2010 13:18:37 -0700	[thread overview]
Message-ID: <20100525201837.GA13821@kroah.com> (raw)
In-Reply-To: <alpine.WNT.2.00.1005250926320.2708@jbrandeb-desk1.amr.corp.intel.com>

On Tue, May 25, 2010 at 09:27:25AM -0700, Brandeburg, Jesse wrote:
> 
> 
> On Tue, 25 May 2010, Jeff Kirsher wrote:
> 
> > On Mon, May 10, 2010 at 17:46, Jeff Kirsher <jeffrey.t.kirsher@intel.com> wrote:
> > > From: Jesse Brandeburg <jesse.brandeburg@intel.com>
> > >
> > > backporting this commit:
> > >
> > > commit fdd3d631cddad20ad9d3e1eb7dbf26825a8a121f
> > > Author: Krishna Kumar <krkumar2@in.ibm.com>
> > > Date:   Wed Feb 3 13:13:10 2010 +0000
> > >
> > >    ixgbe: Fix return of invalid txq
> > >
> > >    a developer had complained of getting lots of warnings:
> > >
> > >    "eth16 selects TX queue 98, but real number of TX queues is 64"
> > >
> > >    http://www.mail-archive.com/e1000-devel@lists.sourceforge.net/msg02200.html
> > >
> > >    As there was no follow up on that bug, I am submitting this
> > >    patch assuming that the other return points will not return
> > >    invalid txq's, and also that this fixes the bug (not tested).
> > >
> > >    Signed-off-by: Krishna Kumar <krkumar2@in.ibm.com>
> > >    Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> > >    Acked-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
> > >    Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> > >    Signed-off-by: David S. Miller <davem@davemloft.net>
> > >
> > > CC: Brandon <brandon@ifup.org>
> > > Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> > > ---
> > >
> > >  drivers/net/ixgbe/ixgbe_main.c |    8 ++++++--
> > >  1 files changed, 6 insertions(+), 2 deletions(-)
> > >
> > 
> > Greg - status?  Did you queue this patch for the stable release and I missed it?
> 
> Maybe we didn't say (and we should have) that this fixes a panic on 
> machines with > 64 cores.  Please apply to -stable 32.

I'll get to it for the next release after this one, if that's ok.

thanks,

greg k-h

  reply	other threads:[~2010-05-25 20:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-11  0:46 [stable-2.6.32 PATCH] ixgbe: backport bug fix for tx panic Jeff Kirsher
2010-05-25  7:15 ` Jeff Kirsher
2010-05-25 16:27   ` Brandeburg, Jesse
2010-05-25 20:18     ` Greg KH [this message]
2010-07-02 21:37       ` [stable] " Jeff Kirsher
2010-07-03  2:28         ` Greg KH
2010-05-25 18:19   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100525201837.GA13821@kroah.com \
    --to=greg@kroah.com \
    --cc=brandon@ifup.org \
    --cc=davem@davemloft.net \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=jesse.brandeburg@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).