From: David Miller <davem@davemloft.net>
To: error27@gmail.com
Cc: netdev@vger.kernel.org, kuznet@ms2.inr.ac.ru, pekkas@netcore.fi,
jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net,
eric.dumazet@gmail.com
Subject: Re: [patch] ipmr: off by one in __ipmr_fill_mroute()
Date: Wed, 26 May 2010 00:39:16 -0700 (PDT) [thread overview]
Message-ID: <20100526.003916.39169713.davem@davemloft.net> (raw)
In-Reply-To: <20100522175357.GF22515@bicker>
From: Dan Carpenter <error27@gmail.com>
Date: Sat, 22 May 2010 19:54:48 +0200
> This fixes a smatch warning:
> net/ipv4/ipmr.c +1917 __ipmr_fill_mroute(12) error: buffer overflow
> '(mrt)->vif_table' 32 <= 32
>
> The ipv6 version had the same issue.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Introduced by commit "7438189b".
Applied, thanks Dan.
prev parent reply other threads:[~2010-05-26 7:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-22 17:54 [patch] ipmr: off by one in __ipmr_fill_mroute() Dan Carpenter
2010-05-26 7:39 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100526.003916.39169713.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=error27@gmail.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=netdev@vger.kernel.org \
--cc=pekkas@netcore.fi \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).