From: David Miller <davem@davemloft.net>
To: anton@samba.org
Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org
Subject: Re: Warning in net/ipv4/af_inet.c:154
Date: Wed, 26 May 2010 00:56:34 -0700 (PDT) [thread overview]
Message-ID: <20100526.005634.48509140.davem@davemloft.net> (raw)
In-Reply-To: <20100526031943.GA28295@kryten>
From: Anton Blanchard <anton@samba.org>
Date: Wed, 26 May 2010 13:19:43 +1000
> I notice we update sk_forward_alloc in sk_mem_charge and sk_mem_uncharge.
> Since it isn't an atomic variable I went looking for a lock somewhere in
> the call chain (first thought was the socket lock). I couldn't find
> anything, but I could easily be missing something.
We take the lock properly for all of the skb_queue_rcv_skb() cases
but this rule isn't followed properly for skb_queue_err_skb().
Eric, look at even things like skb_tstamp_tx(). Nothing locks the
socket in those cases, yet we dip down into sock_queue_err_skb() and
thus invoke skb_set_owner_r which goes into sk_mem_charge() and does
the non-atomic update on ->sk_forward_alloc.
I am sure there are other cases with this problem involving
sock_queue_err_skb()... ip_icmp_error() (via __udp4_lib_err()),
ipv6_icmp_error(), etc.
next prev parent reply other threads:[~2010-05-26 7:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-25 11:58 Warning in net/ipv4/af_inet.c:154 Anton Blanchard
2010-05-25 15:27 ` Eric Dumazet
2010-05-26 3:19 ` Anton Blanchard
2010-05-26 5:18 ` Eric Dumazet
2010-05-26 7:56 ` David Miller [this message]
2010-05-26 10:12 ` Eric Dumazet
2010-05-27 3:56 ` Anton Blanchard
2010-05-27 4:06 ` David Miller
2010-05-27 4:21 ` Eric Dumazet
2010-05-27 4:18 ` Eric Dumazet
2010-05-27 4:21 ` David Miller
2010-05-27 5:06 ` [PATCH] net: fix lock_sock_bh/unlock_sock_bh Eric Dumazet
2010-05-27 5:20 ` Eric Dumazet
2010-05-27 5:23 ` David Miller
2010-05-27 6:09 ` Anton Blanchard
2010-05-27 7:29 ` David Miller
2010-05-29 7:21 ` Warning in net/ipv4/af_inet.c:154 David Miller
2010-05-31 16:02 ` [PATCH] net: sock_queue_err_skb() dont mess with sk_forward_alloc Eric Dumazet
2010-06-01 6:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100526.005634.48509140.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=anton@samba.org \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).