* [patch 2/2] be2net: remove superfluous externs
@ 2010-05-26 14:47 Dan Carpenter
2010-05-27 6:32 ` Sarveshwar Bandi
2010-05-29 7:20 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2010-05-26 14:47 UTC (permalink / raw)
To: Sathya Perla
Cc: Subbu Seetharaman, Sarveshwar Bandi, Ajit Khaparde,
David S. Miller, netdev, kernel-janitors
This fixes some sparse warnings:
drivers/net/benet/be_cmds.c:1503:12: warning: function
'be_cmd_enable_magic_wol' with external linkage has definition
drivers/net/benet/be_cmds.c:1668:12: warning: function
'be_cmd_get_seeprom_data' with external linkage has definition
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/net/benet/be_cmds.c b/drivers/net/benet/be_cmds.c
index c911bfb..f9c0d4d 100644
--- a/drivers/net/benet/be_cmds.c
+++ b/drivers/net/benet/be_cmds.c
@@ -1497,7 +1500,7 @@ err:
return status;
}
-extern int be_cmd_enable_magic_wol(struct be_adapter *adapter, u8 *mac,
+int be_cmd_enable_magic_wol(struct be_adapter *adapter, u8 *mac,
struct be_dma_mem *nonemb_cmd)
{
struct be_mcc_wrb *wrb;
@@ -1662,7 +1665,7 @@ err:
return status;
}
-extern int be_cmd_get_seeprom_data(struct be_adapter *adapter,
+int be_cmd_get_seeprom_data(struct be_adapter *adapter,
struct be_dma_mem *nonemb_cmd)
{
struct be_mcc_wrb *wrb;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [patch 2/2] be2net: remove superfluous externs
2010-05-26 14:47 [patch 2/2] be2net: remove superfluous externs Dan Carpenter
@ 2010-05-27 6:32 ` Sarveshwar Bandi
2010-05-29 7:20 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Sarveshwar Bandi @ 2010-05-27 6:32 UTC (permalink / raw)
To: Dan Carpenter
Cc: Sathya Perla, Subbu Seetharaman, Ajit Khaparde, David S. Miller,
netdev, kernel-janitors
Thanks.
Acked-by: Sarveshwar Bandi <sarveshwarb@serverengines.com>
On 26/05/10 16:47 +0200, Dan Carpenter wrote:
> This fixes some sparse warnings:
> drivers/net/benet/be_cmds.c:1503:12: warning: function
> 'be_cmd_enable_magic_wol' with external linkage has definition
> drivers/net/benet/be_cmds.c:1668:12: warning: function
> 'be_cmd_get_seeprom_data' with external linkage has definition
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
>
> diff --git a/drivers/net/benet/be_cmds.c b/drivers/net/benet/be_cmds.c
> index c911bfb..f9c0d4d 100644
> --- a/drivers/net/benet/be_cmds.c
> +++ b/drivers/net/benet/be_cmds.c
> @@ -1497,7 +1500,7 @@ err:
> return status;
> }
>
> -extern int be_cmd_enable_magic_wol(struct be_adapter *adapter, u8 *mac,
> +int be_cmd_enable_magic_wol(struct be_adapter *adapter, u8 *mac,
> struct be_dma_mem *nonemb_cmd)
> {
> struct be_mcc_wrb *wrb;
> @@ -1662,7 +1665,7 @@ err:
> return status;
> }
>
> -extern int be_cmd_get_seeprom_data(struct be_adapter *adapter,
> +int be_cmd_get_seeprom_data(struct be_adapter *adapter,
> struct be_dma_mem *nonemb_cmd)
> {
> struct be_mcc_wrb *wrb;
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch 2/2] be2net: remove superfluous externs
2010-05-26 14:47 [patch 2/2] be2net: remove superfluous externs Dan Carpenter
2010-05-27 6:32 ` Sarveshwar Bandi
@ 2010-05-29 7:20 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2010-05-29 7:20 UTC (permalink / raw)
To: error27; +Cc: sathyap, subbus, sarveshwarb, ajitk, netdev, kernel-janitors
From: Dan Carpenter <error27@gmail.com>
Date: Wed, 26 May 2010 16:47:39 +0200
> This fixes some sparse warnings:
> drivers/net/benet/be_cmds.c:1503:12: warning: function
> 'be_cmd_enable_magic_wol' with external linkage has definition
> drivers/net/benet/be_cmds.c:1668:12: warning: function
> 'be_cmd_get_seeprom_data' with external linkage has definition
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-05-29 7:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-26 14:47 [patch 2/2] be2net: remove superfluous externs Dan Carpenter
2010-05-27 6:32 ` Sarveshwar Bandi
2010-05-29 7:20 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).