From: Ralf Baechle <ralf@linux-mips.org>
To: Herbert Xu <herbert@gondor.hengli.com.au>
Cc: "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: ipv6: Add GSO support on forwarding path
Date: Wed, 26 May 2010 16:20:19 +0100 [thread overview]
Message-ID: <20100526152019.GA11985@linux-mips.org> (raw)
In-Reply-To: <20100526102758.GA25914@gondor.apana.org.au>
On Wed, May 26, 2010 at 08:27:58PM +1000, Herbert Xu wrote:
> ipv6: Add GSO support on forwarding path
>
> Currently we disallow GSO packets on the IPv6 forward path.
> This patch fixes this.
>
> Note that I discovered that our existing GSO MTU checks (e.g.,
> IPv4 forwarding) are buggy in that they skip the check altogether,
> hen they really should be checking gso_size instead.
>
> I have also been lazy here in that I haven't bothered to segment
> the GSO packet by hand before generating an ICMP message. Someone
> should add that to be 100% correct.
>
> Reported-by: Ralf Baechle <ralf@linux-mips.org>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
I tested this on top of a 2.6.34 release kernel and asked the user
experiencing the problem to re-test and the problem still persists.
Unlike what I told you earlier on IRC my tester can trigger the issue
by going to any page on linux-ax25.org from any XP, Vista or Windows 7
client.
I've got three tcpdumps of the hang occuring on ftp.linux-ax25.org
/pub/dl1bff.log
/pub/dl1bff-2.log
/pub/dl1bff-3.log
The first two were taken with a 2.6.32 Fedora 12 kernel; the 3rd with
a stock 2.6.34 kernel and your patch applied on top. The issue exists
for quite a while; it has first been noticed with Fedora 11.
Ralf
next prev parent reply other threads:[~2010-05-26 15:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-26 10:27 ipv6: Add GSO support on forwarding path Herbert Xu
2010-05-26 15:20 ` Ralf Baechle [this message]
2010-05-26 22:16 ` Herbert Xu
2010-05-27 9:22 ` Ralf Baechle
2010-05-27 10:14 ` Ralf Baechle
2010-05-27 10:24 ` Herbert Xu
2010-05-27 11:54 ` Herbert Xu
2010-05-27 23:14 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100526152019.GA11985@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.hengli.com.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).