From: David Miller <davem@davemloft.net>
To: scofeldm@cisco.com
Cc: chrisw@redhat.com, netdev@vger.kernel.org, kaber@trash.net,
arnd@arndb.de
Subject: Re: [net-2.6 PATCH 1/2] netlink: bug fix: don't overrun skbs on vf_port dump
Date: Fri, 28 May 2010 03:42:51 -0700 (PDT) [thread overview]
Message-ID: <20100528.034251.242153540.davem@davemloft.net> (raw)
In-Reply-To: <20100528071546.4058.1332.stgit@localhost.localdomain>
From: Scott Feldman <scofeldm@cisco.com>
Date: Fri, 28 May 2010 00:15:46 -0700
> From: Scott Feldman <scofeldm@cisco.com>
>
> Noticed by Patrick McHardy: was continuing to fill skb after a
> nla_put_failure, ignoring the size calculated by upper layer. Now,
> return -EMSGSIZE on any overruns, but also allow netdev to
> fail ndo_get_vf_port with error other than -EMSGSIZE, thus unwinding
> nest.
>
> Signed-off-by: Scott Feldman <scofeldm@cisco.com>
Applied.
prev parent reply other threads:[~2010-05-28 10:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-28 7:15 [net-2.6 PATCH 1/2] netlink: bug fix: don't overrun skbs on vf_port dump Scott Feldman
2010-05-28 7:15 ` [net-2.6 PATCH 2/2] netlink: bug fix: wrong size was calculated for vfinfo list blob Scott Feldman
2010-05-28 10:42 ` David Miller
2010-05-28 10:42 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100528.034251.242153540.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=arnd@arndb.de \
--cc=chrisw@redhat.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=scofeldm@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).