From: David Miller <davem@davemloft.net>
To: grundler@parisc-linux.org
Cc: mchan@broadcom.com, netdev@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH] bnx2: Fix IRQ failures during kdump.
Date: Fri, 28 May 2010 23:50:52 -0700 (PDT) [thread overview]
Message-ID: <20100528.235052.241451895.davem@davemloft.net> (raw)
In-Reply-To: <20100529064512.GA21336@lackof.org>
From: Grant Grundler <grundler@parisc-linux.org>
Date: Sat, 29 May 2010 00:45:12 -0600
> If that's true, then this can't be handled in the generic PCI layer (as
> suggested by davem) unless the device driver could register multiple interrupt
> handlers even if only one is active at a time.
The generic PCI layer very well can turn off MSI on all devices
when it starts up or a device is plugged in.
That's all he is doing.
Drivers essentially expect that the device comes up in INTX mode
when the driver probes the device. All his change is doing
is forcing that to be true, and there is no reason the generic
PCI code can't do that.
next prev parent reply other threads:[~2010-05-29 6:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-29 3:24 [PATCH] bnx2: Fix IRQ failures during kdump Michael Chan
2010-05-29 5:33 ` David Miller
2010-05-29 6:45 ` Grant Grundler
2010-05-29 6:50 ` David Miller [this message]
2010-05-29 16:22 ` Michael Chan
2010-05-29 23:05 ` David Miller
2010-05-30 1:24 ` Matthew Wilcox
2010-05-30 3:49 ` David Miller
2010-05-30 9:44 ` Andi Kleen
2010-05-30 16:32 ` Michael Chan
2010-05-29 16:01 ` Stephen Hemminger
2010-05-30 9:43 ` Andi Kleen
2010-05-30 16:12 ` Michael Chan
2010-05-30 17:30 ` Andi Kleen
2010-05-31 4:43 ` Michael Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100528.235052.241451895.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=grundler@parisc-linux.org \
--cc=linux-pci@vger.kernel.org \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).