From: David Miller <davem@davemloft.net>
To: junchangwang@gmail.com
Cc: romieu@fr.zoreil.com, netdev@vger.kernel.org
Subject: Re: [Patch] r8169: use u32 instead of unsigned long
Date: Fri, 28 May 2010 23:53:24 -0700 (PDT) [thread overview]
Message-ID: <20100528.235324.52183500.davem@davemloft.net> (raw)
In-Reply-To: <20100529040111.GA28225@host-a-55.ustcsz.edu.cn>
From: Junchang Wang <junchangwang@gmail.com>
Date: Sat, 29 May 2010 12:01:11 +0800
> RTL_R32 should return value with 32-bit width. But "unsigned long"
> implies u64 on some 64-bit platforms.
>
> Signed-off-by: Junchang Wang <junchangwang@gmail.com>
I fail to see why there is a need to cast the return value
of readl() at all.
It returns a 32-bit integer on all platforms.
Secondly, 8139too.c has the same unnecessary cast.
So the thing to do is to kill the casts completely from both
drivers defining this register read macro.
next prev parent reply other threads:[~2010-05-29 6:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-29 4:01 [Patch] r8169: use u32 instead of unsigned long Junchang Wang
2010-05-29 6:53 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-05-26 14:01 Junchang Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100528.235324.52183500.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=junchangwang@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).