From: David Miller <davem@davemloft.net>
To: eric@eukrea.com
Cc: s.hauer@pengutronix.de, sshtylyov@mvista.com,
linux-arm-kernel@lists.infradead.org, fabioestevam@yahoo.com,
netdev@vger.kernel.org
Subject: Re: [PATCH] net/fec: fix pm to survive to suspend/resume
Date: Sat, 29 May 2010 00:15:34 -0700 (PDT) [thread overview]
Message-ID: <20100529.001534.57459102.davem@davemloft.net> (raw)
In-Reply-To: <1274982828-13082-1-git-send-email-eric@eukrea.com>
From: Eric Bénard <eric@eukrea.com>
Date: Thu, 27 May 2010 19:53:48 +0200
> * with this patch, if the connection if active before suspend, it
> will be active after resume.
> * before this patch, it was necessary to close the interface and
> reopen it to recover the connection.
>
> Signed-off-by: Eric Bénard <eric@eukrea.com>
On resume the PHY should be reset and the link renegotiated (or set to
a fixed speed/duplex if set by the user via ethtool) just like as
happens on ->open().
You seem to be avoiding that here.
If the PHY is not functioning properly after the ->resume() triggered
reset, fix that instead.
I'm not applying this patch, it doesn't look the right thing to do at
all.
next prev parent reply other threads:[~2010-05-29 7:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <536177.31761.qm@web51001.mail.re2.yahoo.com>
2010-05-27 17:53 ` [PATCH] net/fec: fix pm to survive to suspend/resume Eric Bénard
2010-05-29 7:15 ` David Miller [this message]
2010-05-29 20:04 ` [PATCH v2] " Eric Bénard
2010-06-02 13:13 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100529.001534.57459102.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric@eukrea.com \
--cc=fabioestevam@yahoo.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sshtylyov@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).