From: David Miller <davem@davemloft.net>
To: mware@elphinstone.net
Cc: linuxppc-dev@ozlabs.org, netdev@vger.kernel.org,
vbordug@ru.mvista.com, pantelis.antoniou@gmail.com
Subject: Re: [PATCH] fs_enet: Adjust BDs after tx error
Date: Sat, 29 May 2010 00:16:36 -0700 (PDT) [thread overview]
Message-ID: <20100529.001636.42779529.davem@davemloft.net> (raw)
In-Reply-To: <4BFDC6EC.9090804@elphinstone.net>
From: Mark Ware <mware@elphinstone.net>
Date: Thu, 27 May 2010 11:12:12 +1000
> This patch fixes an occasional transmit lockup in the mac-fcc which
> occurs after a tx error. The test scenario had the local port set
> to autoneg and the other end fixed at 100FD, resulting in a large
> number of late collisions.
>
> According to the MPC8280RM 30.10.1.3 (also 8272RM 29.10.1.3), after
> a tx error occurs, TBPTR may sometimes point beyond BDs still marked
> as ready. This patch walks back through the BDs and points TBPTR to
> the earliest one marked as ready.
>
> Tested on a custom board with a MPC8280.
>
> Signed-off-by: Mark Ware <mware@elphinstone.net>
Applied, thanks.
prev parent reply other threads:[~2010-05-29 7:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-27 1:12 [PATCH] fs_enet: Adjust BDs after tx error Mark Ware
2010-05-29 7:16 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100529.001636.42779529.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linuxppc-dev@ozlabs.org \
--cc=mware@elphinstone.net \
--cc=netdev@vger.kernel.org \
--cc=pantelis.antoniou@gmail.com \
--cc=vbordug@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).