From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: anton@samba.org, netdev@vger.kernel.org
Subject: Re: Warning in net/ipv4/af_inet.c:154
Date: Sat, 29 May 2010 00:21:24 -0700 (PDT) [thread overview]
Message-ID: <20100529.002124.149815573.davem@davemloft.net> (raw)
In-Reply-To: <1274868776.2672.96.camel@edumazet-laptop>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 26 May 2010 12:12:56 +0200
> [PATCH] net: fix sk_forward_alloc corruptions
>
> As David found out, sock_queue_err_skb() should be called with socket
> lock hold, or we risk sk_forward_alloc corruption, since we use non
> atomic operations to update this field.
>
> This patch adds bh_lock_sock()/bh_unlock_sock() pair to three spots.
> (BH already disabled)
>
> 1) skb_tstamp_tx()
> 2) Before calling ip_icmp_error(), in __udp4_lib_err()
> 3) Before calling ipv6_icmp_error(), in __udp6_lib_err()
>
> Reported-by: Anton Blanchard <anton@samba.org>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
This wasn't the direct cause of Anton's problems but is
a serious legitimate bug.
So, applied, thanks!
next prev parent reply other threads:[~2010-05-29 7:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-25 11:58 Warning in net/ipv4/af_inet.c:154 Anton Blanchard
2010-05-25 15:27 ` Eric Dumazet
2010-05-26 3:19 ` Anton Blanchard
2010-05-26 5:18 ` Eric Dumazet
2010-05-26 7:56 ` David Miller
2010-05-26 10:12 ` Eric Dumazet
2010-05-27 3:56 ` Anton Blanchard
2010-05-27 4:06 ` David Miller
2010-05-27 4:21 ` Eric Dumazet
2010-05-27 4:18 ` Eric Dumazet
2010-05-27 4:21 ` David Miller
2010-05-27 5:06 ` [PATCH] net: fix lock_sock_bh/unlock_sock_bh Eric Dumazet
2010-05-27 5:20 ` Eric Dumazet
2010-05-27 5:23 ` David Miller
2010-05-27 6:09 ` Anton Blanchard
2010-05-27 7:29 ` David Miller
2010-05-29 7:21 ` David Miller [this message]
2010-05-31 16:02 ` [PATCH] net: sock_queue_err_skb() dont mess with sk_forward_alloc Eric Dumazet
2010-06-01 6:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100529.002124.149815573.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=anton@samba.org \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).