From: Stephen Hemminger <shemminger@vyatta.com>
To: "Michael Chan" <mchan@broadcom.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH] bnx2: Fix IRQ failures during kdump.
Date: Sat, 29 May 2010 09:01:56 -0700 [thread overview]
Message-ID: <20100529090156.29067f28@nehalam> (raw)
In-Reply-To: <1275103462-8527-1-git-send-email-mchan@broadcom.com>
On Fri, 28 May 2010 20:24:22 -0700
"Michael Chan" <mchan@broadcom.com> wrote:
> When switching from the crashed kernel to the kdump kernel without going
> through PCI reset, IRQs may not work if a different IRQ mode is used on
> the kdump kernel. The original IRQ mode used in the crashed kernel may
> still be enabled and the new IRQ mode may not work. For example, it
> will fail when going from MSI-X mode to MSI mode.
>
> We fix this by disabling MSI/MSI-X and enabling INTX in bnx2_init_board().
>
> pci_save_state() is also moved to the end of bnx2_init_board() after
> all config register fixups (including the new IRQ fixups) have been done.
>
> Export pci_msi_off() from drivers/pci/pci.c for this purpose.
>
> Update bnx2 version to 2.0.16.
This is probably a generic problem for many drivers. So why not
get the kdump code to fix it for all.
next prev parent reply other threads:[~2010-05-29 16:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-29 3:24 [PATCH] bnx2: Fix IRQ failures during kdump Michael Chan
2010-05-29 5:33 ` David Miller
2010-05-29 6:45 ` Grant Grundler
2010-05-29 6:50 ` David Miller
2010-05-29 16:22 ` Michael Chan
2010-05-29 23:05 ` David Miller
2010-05-30 1:24 ` Matthew Wilcox
2010-05-30 3:49 ` David Miller
2010-05-30 9:44 ` Andi Kleen
2010-05-30 16:32 ` Michael Chan
2010-05-29 16:01 ` Stephen Hemminger [this message]
2010-05-30 9:43 ` Andi Kleen
2010-05-30 16:12 ` Michael Chan
2010-05-30 17:30 ` Andi Kleen
2010-05-31 4:43 ` Michael Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100529090156.29067f28@nehalam \
--to=shemminger@vyatta.com \
--cc=davem@davemloft.net \
--cc=linux-pci@vger.kernel.org \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox