netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Phil Sutter <phil@nwl.cc>
To: David Miller <davem@davemloft.net>
Cc: Florian Fainelli <florian@openwrt.org>, netdev@vger.kernel.org
Subject: [PATCH 3/3] korina: count RX DMA OVR as rx_fifo_error
Date: Sun, 30 May 2010 01:23:36 +0200	[thread overview]
Message-ID: <20100529232345.CA3124CD45@orbit.nwl.cc> (raw)
In-Reply-To: <1275175416-21267-2-git-send-email-phil@nwl.cc>

This way, RX DMA overruns (actually being caused by overrun of the
512byte input FIFO) show up in ifconfig output. The rx_fifo_errors
counter is unused otherwise.

Signed-off-by: Phil Sutter <phil@nwl.cc>
---
 drivers/net/korina.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/korina.c b/drivers/net/korina.c
index 3e9b6b7..c7a9bef 100644
--- a/drivers/net/korina.c
+++ b/drivers/net/korina.c
@@ -376,7 +376,7 @@ static int korina_rx(struct net_device *dev, int limit)
 		if (devcs & ETH_RX_LE)
 			dev->stats.rx_length_errors++;
 		if (devcs & ETH_RX_OVR)
-			dev->stats.rx_over_errors++;
+			dev->stats.rx_fifo_errors++;
 		if (devcs & ETH_RX_CV)
 			dev->stats.rx_frame_errors++;
 		if (devcs & ETH_RX_CES)
-- 
1.6.4.4


  parent reply	other threads:[~2010-05-29 23:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1275175416-21267-1-git-send-email-phil@nwl.cc>
2010-05-29 23:23 ` [PATCH 2/3] korina: use netdev_alloc_skb_ip_align() here, too Phil Sutter
2010-06-02 13:12   ` David Miller
     [not found] ` <1275175416-21267-2-git-send-email-phil@nwl.cc>
2010-05-29 23:23   ` Phil Sutter [this message]
2010-06-02 13:13     ` [PATCH 3/3] korina: count RX DMA OVR as rx_fifo_error David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100529232345.CA3124CD45@orbit.nwl.cc \
    --to=phil@nwl.cc \
    --cc=davem@davemloft.net \
    --cc=florian@openwrt.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).