* tcp md5 fraglist... @ 2010-05-18 6:14 David Miller 2010-05-18 6:30 ` Eric Dumazet 2010-05-18 6:40 ` [PATCH] tcp: tcp_md5_hash_skb_data() frag_list handling Eric Dumazet 0 siblings, 2 replies; 5+ messages in thread From: David Miller @ 2010-05-18 6:14 UTC (permalink / raw) To: eric.dumazet; +Cc: netdev Eric, would you please formally submit that tcp md5 fraglist fix to net/ipv4/tcp.c with proper signoffs? Thanks! ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: tcp md5 fraglist... 2010-05-18 6:14 tcp md5 fraglist David Miller @ 2010-05-18 6:30 ` Eric Dumazet 2010-05-18 6:35 ` David Miller 2010-05-18 6:40 ` [PATCH] tcp: tcp_md5_hash_skb_data() frag_list handling Eric Dumazet 1 sibling, 1 reply; 5+ messages in thread From: Eric Dumazet @ 2010-05-18 6:30 UTC (permalink / raw) To: David Miller; +Cc: netdev Le lundi 17 mai 2010 à 23:14 -0700, David Miller a écrit : > Eric, would you please formally submit that tcp md5 fraglist > fix to net/ipv4/tcp.c with proper signoffs? > > Thanks! Sure, will do, but I doubt it is a real problem, because GRO or RSC should not coalesce two segments with MD5 signature (they are guaranteed to differ for each segment ?) ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: tcp md5 fraglist... 2010-05-18 6:30 ` Eric Dumazet @ 2010-05-18 6:35 ` David Miller 0 siblings, 0 replies; 5+ messages in thread From: David Miller @ 2010-05-18 6:35 UTC (permalink / raw) To: eric.dumazet; +Cc: netdev From: Eric Dumazet <eric.dumazet@gmail.com> Date: Tue, 18 May 2010 08:30:24 +0200 > Le lundi 17 mai 2010 à 23:14 -0700, David Miller a écrit : >> Eric, would you please formally submit that tcp md5 fraglist >> fix to net/ipv4/tcp.c with proper signoffs? >> >> Thanks! > > Sure, will do, but I doubt it is a real problem, because GRO or RSC > should not coalesce two segments with MD5 signature (they are guaranteed > to differ for each segment ?) Right, and I just checked that GRO does in fact check if the TCP options are different in any way. ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] tcp: tcp_md5_hash_skb_data() frag_list handling 2010-05-18 6:14 tcp md5 fraglist David Miller 2010-05-18 6:30 ` Eric Dumazet @ 2010-05-18 6:40 ` Eric Dumazet 2010-05-31 7:30 ` David Miller 1 sibling, 1 reply; 5+ messages in thread From: Eric Dumazet @ 2010-05-18 6:40 UTC (permalink / raw) To: David Miller; +Cc: netdev Le lundi 17 mai 2010 à 23:14 -0700, David Miller a écrit : > Eric, would you please formally submit that tcp md5 fraglist > fix to net/ipv4/tcp.c with proper signoffs? Here it is, thanks ! [PATCH] tcp: tcp_md5_hash_skb_data() frag_list handling tcp_md5_hash_skb_data() should handle skb->frag_list, and eventually recurse. Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> --- net/ipv4/tcp.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c index 6596b4f..49d0d2b 100644 --- a/net/ipv4/tcp.c +++ b/net/ipv4/tcp.c @@ -2999,6 +2999,7 @@ int tcp_md5_hash_skb_data(struct tcp_md5sig_pool *hp, const unsigned head_data_len = skb_headlen(skb) > header_len ? skb_headlen(skb) - header_len : 0; const struct skb_shared_info *shi = skb_shinfo(skb); + struct sk_buff *frag_iter; sg_init_table(&sg, 1); @@ -3013,6 +3014,10 @@ int tcp_md5_hash_skb_data(struct tcp_md5sig_pool *hp, return 1; } + skb_walk_frags(skb, frag_iter) + if (tcp_md5_hash_skb_data(hp, frag_iter, 0)) + return 1; + return 0; } ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] tcp: tcp_md5_hash_skb_data() frag_list handling 2010-05-18 6:40 ` [PATCH] tcp: tcp_md5_hash_skb_data() frag_list handling Eric Dumazet @ 2010-05-31 7:30 ` David Miller 0 siblings, 0 replies; 5+ messages in thread From: David Miller @ 2010-05-31 7:30 UTC (permalink / raw) To: eric.dumazet; +Cc: netdev From: Eric Dumazet <eric.dumazet@gmail.com> Date: Tue, 18 May 2010 08:40:51 +0200 > Le lundi 17 mai 2010 à 23:14 -0700, David Miller a écrit : >> Eric, would you please formally submit that tcp md5 fraglist >> fix to net/ipv4/tcp.c with proper signoffs? > > Here it is, thanks ! > > > [PATCH] tcp: tcp_md5_hash_skb_data() frag_list handling > > tcp_md5_hash_skb_data() should handle skb->frag_list, and eventually > recurse. > > Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> Applied. ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-05-31 7:30 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2010-05-18 6:14 tcp md5 fraglist David Miller 2010-05-18 6:30 ` Eric Dumazet 2010-05-18 6:35 ` David Miller 2010-05-18 6:40 ` [PATCH] tcp: tcp_md5_hash_skb_data() frag_list handling Eric Dumazet 2010-05-31 7:30 ` David Miller
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).