* [Patch]r8169: remove unnecessary cast of readl()'s return value
@ 2010-05-30 12:26 Junchang Wang
2010-05-30 17:36 ` Jeff Garzik
2010-05-31 7:33 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Junchang Wang @ 2010-05-30 12:26 UTC (permalink / raw)
To: davem, romieu; +Cc: netdev
readl() returns a 32-bit integer on all platforms.
There is no need to cast its return value.
Signed-off-by: Junchang Wang <junchangwang@gmail.com>
---
drivers/net/r8169.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c
index 217e709..ca93cdf 100644
--- a/drivers/net/r8169.c
+++ b/drivers/net/r8169.c
@@ -88,7 +88,7 @@ static const int multicast_filter_limit = 32;
#define RTL_W32(reg, val32) writel ((val32), ioaddr + (reg))
#define RTL_R8(reg) readb (ioaddr + (reg))
#define RTL_R16(reg) readw (ioaddr + (reg))
-#define RTL_R32(reg) ((unsigned long) readl (ioaddr + (reg)))
+#define RTL_R32(reg) readl (ioaddr + (reg))
enum mac_version {
RTL_GIGA_MAC_NONE = 0x00,
--
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Patch]r8169: remove unnecessary cast of readl()'s return value
2010-05-30 12:26 [Patch]r8169: remove unnecessary cast of readl()'s return value Junchang Wang
@ 2010-05-30 17:36 ` Jeff Garzik
2010-05-31 7:33 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Garzik @ 2010-05-30 17:36 UTC (permalink / raw)
To: davem, romieu, netdev
On 05/30/2010 08:26 AM, Junchang Wang wrote:
> readl() returns a 32-bit integer on all platforms.
> There is no need to cast its return value.
>
> Signed-off-by: Junchang Wang<junchangwang@gmail.com>
> ---
> drivers/net/r8169.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c
> index 217e709..ca93cdf 100644
> --- a/drivers/net/r8169.c
> +++ b/drivers/net/r8169.c
> @@ -88,7 +88,7 @@ static const int multicast_filter_limit = 32;
> #define RTL_W32(reg, val32) writel ((val32), ioaddr + (reg))
> #define RTL_R8(reg) readb (ioaddr + (reg))
> #define RTL_R16(reg) readw (ioaddr + (reg))
> -#define RTL_R32(reg) ((unsigned long) readl (ioaddr + (reg)))
> +#define RTL_R32(reg) readl (ioaddr + (reg))
Ditto last email: have you verified this matches all arch's definition
of readl()?
Jeff
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Patch]r8169: remove unnecessary cast of readl()'s return value
2010-05-30 12:26 [Patch]r8169: remove unnecessary cast of readl()'s return value Junchang Wang
2010-05-30 17:36 ` Jeff Garzik
@ 2010-05-31 7:33 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2010-05-31 7:33 UTC (permalink / raw)
To: junchangwang; +Cc: romieu, netdev
From: Junchang Wang <junchangwang@gmail.com>
Date: Sun, 30 May 2010 20:26:07 +0800
> readl() returns a 32-bit integer on all platforms.
> There is no need to cast its return value.
>
> Signed-off-by: Junchang Wang <junchangwang@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-05-31 7:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-30 12:26 [Patch]r8169: remove unnecessary cast of readl()'s return value Junchang Wang
2010-05-30 17:36 ` Jeff Garzik
2010-05-31 7:33 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).