From: Anatolij Gustschin <agust@denx.de>
To: Wolfgang Grandegger <wg@grandegger.com>
Cc: netdev@vger.kernel.org, socketcan-core@lists.berlios.de,
"David S. Miller" <davem@davemloft.net>,
Grant Likely <grant.likely@secretlab.ca>
Subject: Re: [PATCH] can: mpc5xxx_can.c: Fix build failure
Date: Mon, 31 May 2010 20:54:23 +0200 [thread overview]
Message-ID: <20100531205423.0840fd08@wker> (raw)
In-Reply-To: <4C03FF75.3010208@grandegger.com>
Hi Wolfgang,
On Mon, 31 May 2010 20:27:01 +0200
Wolfgang Grandegger <wg@grandegger.com> wrote:
...
> > @@ -251,7 +251,7 @@ static int __devinit mpc5xxx_can_probe(struct of_device *ofdev,
> > const struct of_device_id *id)
> > {
> > struct mpc5xxx_can_data *data = (struct mpc5xxx_can_data *)id->data;
> > - struct device_node *np = ofdev->node;
> > + struct device_node *np = ofdev->dev.of_node;
> > struct net_device *dev;
> > struct mscan_priv *priv;
> > void __iomem *base;
>
> The patch seems incomplete. I get at least one more warning (because
> I'm compiling for 52xx, I guess):
Yes, this is true. Unfortunately I didn't compile for 5200 and the issue
didn't show up.
> CC drivers/net/can/mscan/mpc5xxx_can.o
> drivers/net/can/mscan/mpc5xxx_can.c: In function 'mpc52xx_can_get_clock':
> drivers/net/can/mscan/mpc5xxx_can.c:76: error: 'struct of_device' has no member named 'node'
>
> Should I send v2? Thanks for fixing that. I also checked the
> sja1000_of_platform driver, which was converted correctly.
I will send v2 patch shortly. Thanks for reporting!
Anatolij
next prev parent reply other threads:[~2010-05-31 18:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-31 16:31 [PATCH] can: mpc5xxx_can.c: Fix build failure Anatolij Gustschin
2010-05-31 18:27 ` Wolfgang Grandegger
2010-05-31 18:54 ` Anatolij Gustschin [this message]
[not found] ` <4C03FF75.3010208-5Yr1BZd7O62+XT7JhA+gdA@public.gmane.org>
2010-06-01 6:20 ` Wolfgang Grandegger
2010-06-01 7:11 ` David Miller
2010-05-31 18:56 ` [PATCH v2] " Anatolij Gustschin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100531205423.0840fd08@wker \
--to=agust@denx.de \
--cc=davem@davemloft.net \
--cc=grant.likely@secretlab.ca \
--cc=netdev@vger.kernel.org \
--cc=socketcan-core@lists.berlios.de \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox