From: David Miller <davem@davemloft.net>
To: scofeldm@cisco.com
Cc: chrisw@redhat.com, netdev@vger.kernel.org
Subject: Re: [net-2.6 PATCH] enic: bug fix: make the set/get netlink VF_PORT support symmetrical
Date: Wed, 02 Jun 2010 02:27:13 -0700 (PDT) [thread overview]
Message-ID: <20100602.022713.85403401.davem@davemloft.net> (raw)
In-Reply-To: <20100601185933.4323.2212.stgit@localhost.localdomain>
From: Scott Feldman <scofeldm@cisco.com>
Date: Tue, 01 Jun 2010 11:59:33 -0700
> From: Scott Feldman <scofeldm@cisco.com>
>
> To make get/set netlink VF_PORT truly symmetrical, we need to keep track
> of what items are set and only return those items on get. Previously, the
> driver wasn't differentiating between a set of attr with a NULL string,
> for example, and not setting the attr at all. We only want to return
> the NULL string if the attr was actually set with a NULL string. Otherwise,
> don't return the attr.
>
> Signed-off-by: Scott Feldman <scofeldm@cisco.com>
Applied, thanks Scott.
prev parent reply other threads:[~2010-06-02 9:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-01 18:59 [net-2.6 PATCH] enic: bug fix: make the set/get netlink VF_PORT support symmetrical Scott Feldman
2010-06-02 9:27 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100602.022713.85403401.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=chrisw@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=scofeldm@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).