From: David Miller <davem@davemloft.net>
To: john.r.fastabend@intel.com
Cc: andy@greyhouse.net, fubar@us.ibm.com, nhorman@tuxdriver.com,
bonding-devel@lists.sourceforge.net, netdev@vger.kernel.org
Subject: Re: [PATCH 2/3] net: fix conflict between null_or_orig and null_or_bond
Date: Wed, 02 Jun 2010 03:35:54 -0700 (PDT) [thread overview]
Message-ID: <20100602.033554.67893995.davem@davemloft.net> (raw)
In-Reply-To: <20100513073111.3528.19949.stgit@jf-dev2-dcblab>
From: John Fastabend <john.r.fastabend@intel.com>
Date: Thu, 13 May 2010 00:31:11 -0700
> If a skb is received on an inactive bond that does not meet
> the special cases checked for by skb_bond_should_drop it should
> only be delivered to exact matches as the comment in
> netif_receive_skb() says.
>
> However because null_or_bond could also be null this is not
> always true. This patch renames null_or_bond to orig_or_bond
> and initializes it to orig_dev. This keeps the intent of
> null_or_bond to pass frames received on VLAN interfaces stacked
> on bonding interfaces without invalidating the statement for
> null_or_orig.
>
> Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
Also applied.
next prev parent reply other threads:[~2010-06-02 10:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-13 7:31 [PATCH 1/3] net: init_vlan should not copy slave or master flags John Fastabend
2010-05-13 7:31 ` [PATCH 2/3] net: fix conflict between null_or_orig and null_or_bond John Fastabend
2010-06-02 10:35 ` David Miller [this message]
2010-05-13 7:31 ` [PATCH 3/3] net: deliver skbs on inactive slaves to exact matches John Fastabend
2010-05-27 4:52 ` John Fastabend
2010-06-02 10:36 ` David Miller
2010-06-02 20:01 ` Jay Vosburgh
2010-06-03 15:19 ` John Fastabend
2010-06-02 10:35 ` [PATCH 1/3] net: init_vlan should not copy slave or master flags David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100602.033554.67893995.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andy@greyhouse.net \
--cc=bonding-devel@lists.sourceforge.net \
--cc=fubar@us.ibm.com \
--cc=john.r.fastabend@intel.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).